Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2854713002: Network service: start the process as early as possible. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network service: start the process as early as possible. That significantly improves the startup performance: if a URL is loaded using commandline flag, starting the network service process early could reduce the timeToOnLoad number (from navigation start to onload event) by 0.5 ~ 1 second. BUG=598073 Review-Url: https://codereview.chromium.org/2854713002 Cr-Commit-Position: refs/heads/master@{#468496} Committed: https://chromium.googlesource.com/chromium/src/+/7fef43e36006a1871f571f1404b87b642a88f13d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/service_manager/service_manager_context.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
3 years, 7 months ago (2017-05-01 21:35:49 UTC) #3
jam
lgtm for now to get the perf numbers up Seems like this will be a ...
3 years, 7 months ago (2017-05-01 23:46:49 UTC) #8
yzshen1
On 2017/05/01 23:46:49, jam wrote: > lgtm for now to get the perf numbers up ...
3 years, 7 months ago (2017-05-01 23:50:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854713002/1
3 years, 7 months ago (2017-05-01 23:51:24 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:57:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fef43e36006a1871f571f1404b8...

Powered by Google App Engine
This is Rietveld 408576698