Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2846393002: Network service: fix perf issue caused by unnecessary DumpWithoutCrashing. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network service: fix perf issue caused by unnecessary DumpWithoutCrashing. And also add a trace event that matches the non-network service path. BUG=598073, 694688 Review-Url: https://codereview.chromium.org/2846393002 Cr-Commit-Position: refs/heads/master@{#468337} Committed: https://chromium.googlesource.com/chromium/src/+/0f27852ca4088b309083e746c3eaab29fb0b4415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M content/browser/loader/navigation_url_loader_network_service.cc View 4 chunks +15 lines, -0 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
3 years, 7 months ago (2017-04-29 01:00:55 UTC) #4
jam
lgtm, nice find!
3 years, 7 months ago (2017-05-01 15:33:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846393002/1
3 years, 7 months ago (2017-05-01 15:44:08 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:10:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f27852ca4088b309083e746c3ea...

Powered by Google App Engine
This is Rietveld 408576698