Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2854693002: Remove a host_resolver()->ClearRules call in a test body and replace it with an AddRule call that h… (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a host_resolver()->ClearRules call in a test body and replace it with an AddRule call that happens in SetUpOnMainThread. This allows us to enforce that mock host resolver isn't modified in a test body. BUG=713847 Review-Url: https://codereview.chromium.org/2854693002 Cr-Commit-Position: refs/heads/master@{#468479} Committed: https://chromium.googlesource.com/chromium/src/+/dd5f1e9961edb89b0df27420a76ed3fcc5703424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/download/save_page_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
jam
3 years, 7 months ago (2017-05-01 21:08:13 UTC) #6
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-01 22:29:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854693002/20001
3 years, 7 months ago (2017-05-01 23:15:54 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:21:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd5f1e9961edb89b0df27420a76e...

Powered by Google App Engine
This is Rietveld 408576698