Remove a host_resolver()->ClearRules call in a test body and replace it with an AddRule call that h…

chrome/browser/download/save_page_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 862 matching lines @@
   void SetUpCommandLine(base::CommandLine* command_line) override {
     SavePageBrowserTest::SetUpCommandLine(command_line);
 
     // Append --site-per-process flag.
     content::IsolateAllSitesForTesting(command_line);
   }
 
   void SetUpOnMainThread() override {
     SavePageBrowserTest::SetUpOnMainThread();
 
+    // Used by the BrokenImage test which depends on *.no.such.host not
+    // resolving to 127.0.0.1
+    host_resolver()->AddRule("no.such.host", "128.0.0.1");
     host_resolver()->AddRule("*", "127.0.0.1");
     ASSERT_TRUE(embedded_test_server()->InitializeAndListen());
     content::SetupCrossSiteRedirector(embedded_test_server());
     embedded_test_server()->StartAcceptingConnections();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SavePageSitePerProcessBrowserTest);
 };
 
@@ skipping 431 matching lines @@
 
   // The original page has 7 iframes. One of them that contains hidden attribute
   // will be excluded from the saved page.
   TestOriginalVsSavedPage(save_page_type, url, 7, 6, expected_substrings);
 }
 
 // Test for saving a page with broken subresources:
 // - Broken, undecodable image (see also https://crbug.com/586680)
 // - Broken link, to unresolvable host (see also https://crbug.com/594219)
 IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest, BrokenImage) {
-  // Clear resolver rules to make sure that *.no.such.host used in the test html
-  // doesn't resolve to 127.0.0.1
-  host_resolver()->ClearRules();
-
   content::SavePageType save_page_type = GetParam();
 
   std::string arr[] = {
       "broken-image.htm: 1e846775-b3ed-4d9c-a124-029554a1eb9d",
   };
   std::vector<std::string> expected_substrings(std::begin(arr), std::end(arr));
 
   GURL url(embedded_test_server()->GetURL("127.0.0.1",
                                           "/save_page/broken-image.htm"));
 
   TestOriginalVsSavedPage(save_page_type, url, 1, 1, expected_substrings);
 }
 
 INSTANTIATE_TEST_CASE_P(
     SaveType,
     SavePageOriginalVsSavedComparisonTest,
     ::testing::Values(content::SAVE_PAGE_TYPE_AS_COMPLETE_HTML,
                       content::SAVE_PAGE_TYPE_AS_MHTML));
 
 }  // namespace