Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1713)

Issue 2854683002: Send a GSB to main thread before switching to it in the middle of scrolling. (Closed)

Created:
3 years, 7 months ago by sahel
Modified:
3 years, 7 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Send a GSB to main thread before switching to it in the middle of scrolling. When wheel scroll latching is enabled, GSB occurs only once in the beginning of a scroll sequence. So, it is possible to need to switch to the main thread scroll handling in the middle of a scroll scroll sequence (e.g. due to a change in main thread scrolling reasons). To have a complete scroll sequence on main thread side and do the scroll chain computation only while handling GSB, this cl sends a GSB to the main thread before sending the GSU that is not handled in the impl thread side. BUG=526463 TEST=AnimateInput/InputHandlerProxyTest.GestureScrollHandlingSwitchedToMainThread/* Review-Url: https://codereview.chromium.org/2854683002 Cr-Commit-Position: refs/heads/master@{#471006} Committed: https://chromium.googlesource.com/chromium/src/+/42f43cb31dd1ab13aa264e62d1967a4dcbd0dfa7

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M content/renderer/input/input_handler_wrapper.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_client.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (21 generated)
sahel
3 years, 7 months ago (2017-05-01 22:21:59 UTC) #13
dtapuska
On 2017/05/01 22:21:59, sahel wrote: lgtm
3 years, 7 months ago (2017-05-09 19:16:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854683002/40001
3 years, 7 months ago (2017-05-09 19:19:46 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/289478)
3 years, 7 months ago (2017-05-09 19:53:58 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854683002/40001
3 years, 7 months ago (2017-05-11 14:51:56 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451866)
3 years, 7 months ago (2017-05-11 16:35:59 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854683002/40001
3 years, 7 months ago (2017-05-11 17:51:18 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 17:58:55 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/42f43cb31dd1ab13aa264e62d196...

Powered by Google App Engine
This is Rietveld 408576698