Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2854663002: Make EnvInputStateController owned by aura::Env. (Closed)

Created:
3 years, 7 months ago by riajiang
Modified:
3 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EnvInputStateController owned by aura::Env. EnvInputStateController::touch_ids_down_ should be a global state and EnvInputStateController is updating global input event states in Env so it makes sense to have Env own EnvInputStateController. BUG=none, releated to https://codereview.chromium.org/2779093004/ TEST=covered by tests Review-Url: https://codereview.chromium.org/2854663002 Cr-Commit-Position: refs/heads/master@{#468745} Committed: https://chromium.googlesource.com/chromium/src/+/717d8eaea3a41525ff8c4d1d9bf06f975e1f02a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M ui/aura/env.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ui/aura/env.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 5 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
riajiang
Hi sadrul@, could you take a look? Thanks!
3 years, 7 months ago (2017-05-01 20:10:45 UTC) #3
sadrul
lgtm
3 years, 7 months ago (2017-05-02 18:10:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854663002/1
3 years, 7 months ago (2017-05-02 19:30:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/717d8eaea3a41525ff8c4d1d9bf06f975e1f02a1
3 years, 7 months ago (2017-05-02 19:35:29 UTC) #13
sadrul
3 years, 7 months ago (2017-05-02 21:46:11 UTC) #14
Message was sent while issue was closed.
In a follow up patch, can you write a test that does this:
 . Create two WindowTreeHost.
 . Send touch-press events to both.
 . Release touch on one.
 . Verify that Env::is_touch_down() returns true

Because with the old code, I think it would return false.

Powered by Google App Engine
This is Rietveld 408576698