Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2854603002: Fix missing headers in brotli (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
Kunihiko Sakamoto, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing headers in brotli Decreased the number of missing header files by 4. BUG=661774 Review-Url: https://codereview.chromium.org/2854603002 Cr-Commit-Position: refs/heads/master@{#468319} Committed: https://chromium.googlesource.com/chromium/src/+/a10837ebfdd79144b6644f33dae60fc66059b760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/brotli/BUILD.gn View 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-01 06:01:44 UTC) #4
wychen
+thakis for the .gn change.
3 years, 7 months ago (2017-05-01 06:02:35 UTC) #6
Nico
lgtm
3 years, 7 months ago (2017-05-01 13:57:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854603002/1
3 years, 7 months ago (2017-05-01 16:05:53 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 16:10:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a10837ebfdd79144b6644f33dae6...

Powered by Google App Engine
This is Rietveld 408576698