Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2854473002: Revert of DevTools: Show screenshots on the main flamechart (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Show screenshots on the main flamechart (patchset #3 id:40001 of https://codereview.chromium.org/2830343004/ ) Reason for revert: Panning does not work, as well as HiDPI. Original issue's description: > DevTools: Show screenshots on the main flamechart > > The patch puts the screenshots on the frame bar and makes it expandable. > > BUG=705054 > > Review-Url: https://codereview.chromium.org/2830343004 > Cr-Commit-Position: refs/heads/master@{#466821} > Committed: https://chromium.googlesource.com/chromium/src/+/575cce8631ed083645523d47a35090d6ca6ccdfd TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=705054 Review-Url: https://codereview.chromium.org/2854473002 Cr-Commit-Position: refs/heads/master@{#468116} Committed: https://chromium.googlesource.com/chromium/src/+/cda69aa7da5a081bd6014c56cadec2902b35f10e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -100 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 4 chunks +26 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js View 7 chunks +22 lines, -76 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
alph
Created Revert of DevTools: Show screenshots on the main flamechart
3 years, 7 months ago (2017-04-28 18:38:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854473002/1
3 years, 7 months ago (2017-04-28 18:39:34 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 20:38:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cda69aa7da5a081bd6014c56cade...

Powered by Google App Engine
This is Rietveld 408576698