Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2830343004: DevTools: Show screenshots on the main flamechart (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show screenshots on the main flamechart The patch puts the screenshots on the frame bar and makes it expandable. BUG=705054 Review-Url: https://codereview.chromium.org/2830343004 Cr-Commit-Position: refs/heads/master@{#466821} Committed: https://chromium.googlesource.com/chromium/src/+/575cce8631ed083645523d47a35090d6ca6ccdfd

Patch Set 1 #

Patch Set 2 : make frames group non-exapndable when there's no screenshots #

Total comments: 2

Patch Set 3 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -53 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 4 chunks +8 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js View 1 2 7 chunks +75 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
alph
3 years, 8 months ago (2017-04-22 01:21:58 UTC) #2
alph
Pavel, ptal
3 years, 8 months ago (2017-04-24 18:47:27 UTC) #8
pfeldman
lgtm https://codereview.chromium.org/2830343004/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js (right): https://codereview.chromium.org/2830343004/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js#newcode587 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:587: var image = await imagePromise; // -------- ASYNC ...
3 years, 8 months ago (2017-04-24 21:07:17 UTC) #9
alph
https://codereview.chromium.org/2830343004/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js (right): https://codereview.chromium.org/2830343004/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js#newcode587 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js:587: var image = await imagePromise; On 2017/04/24 21:07:17, pfeldman ...
3 years, 8 months ago (2017-04-24 21:18:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830343004/40001
3 years, 8 months ago (2017-04-24 21:18:59 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/575cce8631ed083645523d47a35090d6ca6ccdfd
3 years, 8 months ago (2017-04-24 23:26:31 UTC) #16
alph
3 years, 7 months ago (2017-04-28 18:38:41 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2854473002/ by alph@chromium.org.

The reason for reverting is: Panning does not work, as well as HiDPI..

Powered by Google App Engine
This is Rietveld 408576698