Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2854393005: Split the NTP in two targets to use it in ContentSuggestions (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split the NTP in two targets to use it in ContentSuggestions The ntp_internal is using some components of ContentSuggestions. In order to add the header view in Content Suggestions, the files have to be moved to a different target. BUG=717974 Review-Url: https://codereview.chromium.org/2854393005 Cr-Commit-Position: refs/heads/master@{#470287} Committed: https://chromium.googlesource.com/chromium/src/+/6fc6c3d5071745fe9d37f94a772b1e70231f96ee

Patch Set 1 #

Patch Set 2 : Reparent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M ios/chrome/browser/ui/ntp/BUILD.gn View 5 chunks +29 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
gambard
PTAL.
3 years, 7 months ago (2017-05-05 14:48:08 UTC) #2
marq (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-09 09:12:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854393005/20001
3 years, 7 months ago (2017-05-09 09:21:03 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 11:59:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6fc6c3d5071745fe9d37f94a772b...

Powered by Google App Engine
This is Rietveld 408576698