Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: ios/chrome/browser/ui/ntp/BUILD.gn

Issue 2854393005: Split the NTP in two targets to use it in ContentSuggestions (Closed)
Patch Set: Reparent Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/ntp/BUILD.gn
diff --git a/ios/chrome/browser/ui/ntp/BUILD.gn b/ios/chrome/browser/ui/ntp/BUILD.gn
index 0fa5f8a9025232202583d149cfaab079ba457af3..de3ad7a3f30cc4cb48fe74ecc3b027e34496c41e 100644
--- a/ios/chrome/browser/ui/ntp/BUILD.gn
+++ b/ios/chrome/browser/ui/ntp/BUILD.gn
@@ -109,12 +109,37 @@ source_set("ntp") {
]
}
+source_set("ntp_header") {
+ sources = [
+ "google_landing_data_source.h",
+ "new_tab_page_header_constants.h",
+ "new_tab_page_header_constants.mm",
+ "new_tab_page_header_view.h",
+ "new_tab_page_header_view.mm",
+ "new_tab_page_toolbar_controller.h",
+ "new_tab_page_toolbar_controller.mm",
+ ]
+ deps = [
+ "//base",
+ "//components/ntp_tiles",
+ "//components/strings",
+ "//components/toolbar",
+ "//ios/chrome/app/theme",
+ "//ios/chrome/browser/tabs",
+ "//ios/chrome/browser/ui",
+ "//ios/chrome/browser/ui/commands",
+ "//ios/chrome/browser/ui/toolbar",
+ "//ios/chrome/browser/ui/toolbar:resource_macros",
+ "//ios/chrome/common",
+ "//ui/base",
+ ]
+}
+
source_set("ntp_internal") {
sources = [
"centering_scrollview.h",
"centering_scrollview.mm",
"google_landing_consumer.h",
- "google_landing_data_source.h",
"google_landing_mediator.h",
"google_landing_mediator.mm",
"google_landing_view_controller.h",
@@ -133,13 +158,7 @@ source_set("ntp_internal") {
"new_tab_page_bar_item.mm",
"new_tab_page_controller.h",
"new_tab_page_controller.mm",
- "new_tab_page_header_constants.h",
- "new_tab_page_header_constants.mm",
- "new_tab_page_header_view.h",
- "new_tab_page_header_view.mm",
"new_tab_page_panel_protocol.mm",
- "new_tab_page_toolbar_controller.h",
- "new_tab_page_toolbar_controller.mm",
"new_tab_page_view.h",
"new_tab_page_view.mm",
"notification_promo_whats_new.h",
@@ -147,6 +166,9 @@ source_set("ntp_internal") {
"whats_new_header_view.h",
"whats_new_header_view.mm",
]
+ public_deps = [
+ ":ntp_header",
+ ]
deps = [
":ntp",
":resources",
@@ -165,9 +187,7 @@ source_set("ntp_internal") {
"//components/strings",
"//components/suggestions",
"//components/sync_sessions",
- "//components/toolbar",
"//ios/chrome/app/strings",
- "//ios/chrome/app/theme",
"//ios/chrome/browser",
"//ios/chrome/browser/browser_state",
"//ios/chrome/browser/favicon",
@@ -186,7 +206,6 @@ source_set("ntp_internal") {
"//ios/chrome/browser/ui/ntp/recent_tabs",
"//ios/chrome/browser/ui/overscroll_actions",
"//ios/chrome/browser/ui/toolbar",
- "//ios/chrome/browser/ui/toolbar:resource_macros",
"//ios/chrome/browser/web_state_list",
"//ios/chrome/common",
"//ios/public/provider/chrome/browser",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698