Add tests for PathBuilder when certificates are distrusted.

Add tests for PathBuilder when certificates are distrusted.

Review-Url: https://codereview.chromium.org/2854263004
Cr-Commit-Position: refs/heads/master@{#469373}
Committed: https://chromium.googlesource.com/chromium/src/+/25b1d512b060625a2831f2232efc1e06adaba2f2

[eroman, 2017-05-04 02:04:38]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 02:05:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-04 02:05:36]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[mattm, 2017-05-04 02:30:01]

lgtm

https://codereview.chromium.org/2854263004/diff/1/net/cert/internal/path_buil...
File net/cert/internal/path_builder_unittest.cc (right):

https://codereview.chromium.org/2854263004/diff/1/net/cert/internal/path_buil...
net/cert/internal/path_builder_unittest.cc:1118: void RunPathBuilder(const
scoped_refptr<ParsedCertificate>& distrusted_cert,
tests might read more naturally if this was named something like
RunPathBuilderWithDistrustedCert

[commit-bot: I haz the power, 2017-05-04 03:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 03:08:00]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-05-04 16:34:52]

https://codereview.chromium.org/2854263004/diff/1/net/cert/internal/path_buil...
File net/cert/internal/path_builder_unittest.cc (right):

https://codereview.chromium.org/2854263004/diff/1/net/cert/internal/path_buil...
net/cert/internal/path_builder_unittest.cc:1118: void RunPathBuilder(const
scoped_refptr<ParsedCertificate>& distrusted_cert,
On 2017/05/04 02:30:01, mattm wrote:
> tests might read more naturally if this was named something like
> RunPathBuilderWithDistrustedCert

Done.

[eroman, 2017-05-04 16:35:05]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 16:35:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-04 17:09:35]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2017-05-04 17:09:40]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-05-04 17:09:41]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2854263004/#ps20001
(title: "address mattm's feedback")

[commit-bot: I haz the power, 2017-05-04 17:09:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 17:39:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493917780337510,
"parent_rev": "f011a78f3f93e0f52b89b29a4b40b2e2f879733c", "commit_rev":
"25b1d512b060625a2831f2232efc1e06adaba2f2"}

[commit-bot: I haz the power, 2017-05-04 17:39:49]

Description was changed from

==========
Add tests for PathBuilder when certificates are distrusted.
==========

to

==========
Add tests for PathBuilder when certificates are distrusted.

Review-Url: https://codereview.chromium.org/2854263004
Cr-Commit-Position: refs/heads/master@{#469373}
Committed:
https://chromium.googlesource.com/chromium/src/+/25b1d512b060625a2831f2232efc...
==========

[commit-bot: I haz the power, 2017-05-04 17:39:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25b1d512b060625a2831f2232efc...