Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: net/cert/internal/path_builder.h

Issue 2854263004: Add tests for PathBuilder when certificates are distrusted. (Closed)
Patch Set: address mattm's feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/internal/path_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/path_builder.h
diff --git a/net/cert/internal/path_builder.h b/net/cert/internal/path_builder.h
index 04a571a9a3bb3ec47cd2f4023bae0431c5e56b54..5860ed763d6decb411faa9bf6596a20a20e05b7d 100644
--- a/net/cert/internal/path_builder.h
+++ b/net/cert/internal/path_builder.h
@@ -96,6 +96,9 @@ class NET_EXPORT CertPathBuilder {
// was none.
const ResultPath* GetBestValidPath() const;
+ // Resets to the initial value.
+ void Clear();
+
// List of paths that were attempted and the result for each.
std::vector<std::unique_ptr<ResultPath>> paths;
@@ -111,9 +114,6 @@ class NET_EXPORT CertPathBuilder {
// TODO(mattm): allow caller specified hook/callback to extend path
// verification.
//
- // TODO(eroman): The assumption is that |result| is default initialized. Can
- // probably just internalize |result| into CertPathBuilder.
- //
// Creates a CertPathBuilder that attempts to find a path from |cert| to a
// trust anchor in |trust_store|, which satisfies |signature_policy| and is
// valid at |time|. Details of attempted path(s) are stored in |*result|.
« no previous file with comments | « no previous file | net/cert/internal/path_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698