DescriptionRevert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of https://codereview.chromium.org/2849283002/ )
Reason for revert:
Caused https://bugs.chromium.org/p/chromium/issues/detail?id=717395
Got the go ahead to revert over email. Will continue investigating what's going on in the bug as a follow up.
Original issue's description:
> Fix omnibox suggestions being overdrawn with the nav bar.
>
> getLocationInWindow adjusts for the Android nav bar, while the
> positioning of the parent is exclusive of the nav bar. This causes
> the suggestions be too bar left aligned and cut off.
>
> Only visible if you have the nav bar aligned with the start of
> the text (i.e. on the left with LTR text).
>
> BUG=669150
>
> Review-Url: https://codereview.chromium.org/2849283002
> Cr-Commit-Position: refs/heads/master@{#468466}
> Committed: https://chromium.googlesource.com/chromium/src/+/c0fd363129a9a01abe8954eb9b23beadaf6ea984
TBR=mdjones@chromium.org,tedchoc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=669150
Review-Url: https://codereview.chromium.org/2853993002
Cr-Commit-Position: refs/heads/master@{#468567}
Committed: https://chromium.googlesource.com/chromium/src/+/50e675c553115af32441ed00149935ff604fa71e
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|