Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2853993002: Revert of Fix omnibox suggestions being overdrawn with the nav bar. (Closed)

Created:
3 years, 7 months ago by gone
Modified:
3 years, 7 months ago
Reviewers:
mdjones, Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of https://codereview.chromium.org/2849283002/ ) Reason for revert: Caused https://bugs.chromium.org/p/chromium/issues/detail?id=717395 Got the go ahead to revert over email. Will continue investigating what's going on in the bug as a follow up. Original issue's description: > Fix omnibox suggestions being overdrawn with the nav bar. > > getLocationInWindow adjusts for the Android nav bar, while the > positioning of the parent is exclusive of the nav bar. This causes > the suggestions be too bar left aligned and cut off. > > Only visible if you have the nav bar aligned with the start of > the text (i.e. on the left with LTR text). > > BUG=669150 > > Review-Url: https://codereview.chromium.org/2849283002 > Cr-Commit-Position: refs/heads/master@{#468466} > Committed: https://chromium.googlesource.com/chromium/src/+/c0fd363129a9a01abe8954eb9b23beadaf6ea984 TBR=mdjones@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669150 Review-Url: https://codereview.chromium.org/2853993002 Cr-Commit-Position: refs/heads/master@{#468567} Committed: https://chromium.googlesource.com/chromium/src/+/50e675c553115af32441ed00149935ff604fa71e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java View 4 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
gone
Created Revert of Fix omnibox suggestions being overdrawn with the nav bar.
3 years, 7 months ago (2017-05-02 05:29:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853993002/1
3 years, 7 months ago (2017-05-02 05:29:45 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 05:30:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50e675c553115af32441ed001499...

Powered by Google App Engine
This is Rietveld 408576698