Fix omnibox suggestions being overdrawn with the nav bar.

Fix omnibox suggestions being overdrawn with the nav bar.

getLocationInWindow adjusts for the Android nav bar, while the
positioning of the parent is exclusive of the nav bar.  This causes
the suggestions be too bar left aligned and cut off.

Only visible if you have the nav bar aligned with the start of
the text (i.e. on the left with LTR text).

BUG=669150
Review-Url: https://codereview.chromium.org/2849283002
Cr-Commit-Position: refs/heads/master@{#468466}
Committed: https://chromium.googlesource.com/chromium/src/+/c0fd363129a9a01abe8954eb9b23beadaf6ea984

[Ted C, 2017-05-01 21:25:38]

tedchoc@chromium.org changed reviewers:
+ mdjones@chromium.org

[Ted C, 2017-05-01 21:25:39]

PTAL

[mdjones, 2017-05-01 21:43:23]

"cases" -> "causes" in description, otherwise lgtm

[Ted C, 2017-05-01 21:51:31]

Description was changed from

==========
Fix omnibox suggestions being overdrawn with the nav bar.

getLocationInWindow adjusts for the Android nav bar, while the
positioning of the parent is exclusive of the nav bar.  This cases
the suggestions be too bar left aligned and cut off.

Only visible if you have the nav bar aligned with the start of
the text (i.e. on the left with LTR text).

BUG=669150
==========

to

==========
Fix omnibox suggestions being overdrawn with the nav bar.

getLocationInWindow adjusts for the Android nav bar, while the
positioning of the parent is exclusive of the nav bar.  This causes
the suggestions be too bar left aligned and cut off.

Only visible if you have the nav bar aligned with the start of
the text (i.e. on the left with LTR text).

BUG=669150
==========

[Ted C, 2017-05-01 21:51:38]

On 2017/05/01 21:43:23, mdjones wrote:
> "cases" -> "causes" in description, otherwise lgtm

Done

[Ted C, 2017-05-01 21:51:41]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-05-01 21:52:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 22:47:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493675501149470, "parent_rev":
"3985280845a1a6b0cac775e1fe2be396f0c42bce", "commit_rev":
"c0fd363129a9a01abe8954eb9b23beadaf6ea984"}

[commit-bot: I haz the power, 2017-05-01 22:47:40]

Description was changed from

==========
Fix omnibox suggestions being overdrawn with the nav bar.

getLocationInWindow adjusts for the Android nav bar, while the
positioning of the parent is exclusive of the nav bar.  This causes
the suggestions be too bar left aligned and cut off.

Only visible if you have the nav bar aligned with the start of
the text (i.e. on the left with LTR text).

BUG=669150
==========

to

==========
Fix omnibox suggestions being overdrawn with the nav bar.

getLocationInWindow adjusts for the Android nav bar, while the
positioning of the parent is exclusive of the nav bar.  This causes
the suggestions be too bar left aligned and cut off.

Only visible if you have the nav bar aligned with the start of
the text (i.e. on the left with LTR text).

BUG=669150

Review-Url: https://codereview.chromium.org/2849283002
Cr-Commit-Position: refs/heads/master@{#468466}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0fd363129a9a01abe8954eb9b23...
==========

[commit-bot: I haz the power, 2017-05-01 22:47:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0fd363129a9a01abe8954eb9b23...

[gone, 2017-05-02 05:29:25]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2853993002/ by dfalcantara@chromium.org.

The reason for reverting is: Caused
https://bugs.chromium.org/p/chromium/issues/detail?id=717395

Got the go ahead to revert over email.  Will continue investigating what's going
on in the bug as a follow up..