Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2853783002: Split GN target v8_headers for browser non-code dependency (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Split GN target v8_headers for browser non-code dependency This is for https://crrev.com/2851953002/ BUG=chromium:716359 Review-Url: https://codereview.chromium.org/2853783002 Cr-Commit-Position: refs/heads/master@{#45009} Committed: https://chromium.googlesource.com/v8/v8/+/c1e24b60875991f3e7be47e657a2515b29f19040

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M BUILD.gn View 1 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-01 06:05:21 UTC) #8
wychen
PTAL
3 years, 7 months ago (2017-05-01 06:05:22 UTC) #9
Yang
3 years, 7 months ago (2017-05-01 06:09:34 UTC) #11
Michael Achenbach
lgtm
3 years, 7 months ago (2017-05-02 07:48:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853783002/20001
3 years, 7 months ago (2017-05-02 08:17:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/c1e24b60875991f3e7be47e657a2515b29f19040
3 years, 7 months ago (2017-05-02 08:49:45 UTC) #17
Michael Achenbach
Please wait >2 days for landing the dependent Chromium change to guarantee backwards compatibility to ...
3 years, 7 months ago (2017-05-02 09:02:15 UTC) #18
wychen
Is it OK to land https://codereview.chromium.org/2851953002/ now?
3 years, 7 months ago (2017-05-04 20:27:01 UTC) #19
Michael Achenbach
3 years, 7 months ago (2017-05-04 20:47:05 UTC) #20
Message was sent while issue was closed.
go ahead. we rolled quite frequently.

Powered by Google App Engine
This is Rietveld 408576698