|
|
DescriptionSplit GN target v8_headers for browser non-code dependency
This is for https://crrev.com/2851953002/
BUG=chromium:716359
Review-Url: https://codereview.chromium.org/2853783002
Cr-Commit-Position: refs/heads/master@{#45009}
Committed: https://chromium.googlesource.com/v8/v8/+/c1e24b60875991f3e7be47e657a2515b29f19040
Patch Set 1 #Patch Set 2 : format #Messages
Total messages: 20 (11 generated)
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Split GN target v8_headers for browser non-code dependency BUG=716359 ========== to ========== Split GN target v8_headers for browser non-code dependency This is for https://crrev.com/2851953002/ BUG=716359 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40179)
Description was changed from ========== Split GN target v8_headers for browser non-code dependency This is for https://crrev.com/2851953002/ BUG=716359 ========== to ========== Split GN target v8_headers for browser non-code dependency This is for https://crrev.com/2851953002/ BUG= chromium:716359 ==========
wychen@chromium.org changed reviewers: + yangguo@chromium.org
PTAL
PTAL
yangguo@chromium.org changed reviewers: + machenbach@chromium.org
lgtm
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493713076917090, "parent_rev": "c507fdaffc9430f9d254b11b4ef785554c33b9f4", "commit_rev": "c1e24b60875991f3e7be47e657a2515b29f19040"}
Message was sent while issue was closed.
Description was changed from ========== Split GN target v8_headers for browser non-code dependency This is for https://crrev.com/2851953002/ BUG= chromium:716359 ========== to ========== Split GN target v8_headers for browser non-code dependency This is for https://crrev.com/2851953002/ BUG= chromium:716359 Review-Url: https://codereview.chromium.org/2853783002 Cr-Commit-Position: refs/heads/master@{#45009} Committed: https://chromium.googlesource.com/v8/v8/+/c1e24b60875991f3e7be47e657a2515b29f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/c1e24b60875991f3e7be47e657a2515b29f...
Message was sent while issue was closed.
Please wait >2 days for landing the dependent Chromium change to guarantee backwards compatibility to our last canary.
Message was sent while issue was closed.
Is it OK to land https://codereview.chromium.org/2851953002/ now?
Message was sent while issue was closed.
go ahead. we rolled quite frequently. |