Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: BUILD.gn

Issue 2853783002: Split GN target v8_headers for browser non-code dependency (Closed)
Patch Set: format Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 7e78fb0c6c5d34997c9702ef6b3eea296b5bab10..7c2f052f20ed6036605e716a586b19a6188a7e57 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1018,6 +1018,21 @@ v8_header_set("v8_version") {
]
}
+# This is split out to be a non-code containing target that the Chromium browser
+# can depend upon to get basic v8 types.
+v8_header_set("v8_headers") {
+ configs = [ ":internal_config" ]
+
+ sources = [
+ "include/v8.h",
+ "include/v8config.h",
+ ]
+
+ deps = [
+ ":v8_version",
+ ]
+}
+
v8_source_set("v8_base") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
@@ -2366,9 +2381,9 @@ v8_source_set("v8_base") {
defines = []
deps = [
+ ":v8_headers",
":v8_libbase",
":v8_libsampler",
- ":v8_version",
"src/inspector:inspector",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698