Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2853763005: Don't enable the DSE geolocation setting until EULA accepted (Closed)

Created:
3 years, 7 months ago by benwells
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Don't enable the DSE geolocation setting until EULA accepted This does two things. Firstly it prevents the DSE getting opt-out access to the geolocation API before the EULA is accepted. Secondly, it prevents the search geolocation disclosure from being shown before the EULA is accepted (e.g. on the privacy policy). BUG=713590 Review-Url: https://codereview.chromium.org/2827333004 Cr-Commit-Position: refs/heads/master@{#466548} (cherry picked from commit 2ae9cf3f8288419c4985e4543bcd07ebf65bfd21) Review-Url: https://codereview.chromium.org/2853763005 . Cr-Commit-Position: refs/branch-heads/3071@{#338} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/5929a6d1f6f72bf674aa18906e6b68d729002226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/android/search_geolocation/search_geolocation_service.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
benwells
3 years, 7 months ago (2017-05-02 01:50:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5929a6d1f6f72bf674aa18906e6b68d729002226.

Powered by Google App Engine
This is Rietveld 408576698