Don't enable the DSE geolocation setting until EULA accepted

Don't enable the DSE geolocation setting until EULA accepted

This does two things. Firstly it prevents the DSE getting opt-out access to the geolocation API before the EULA is accepted. Secondly, it prevents the search geolocation disclosure from being shown before the EULA is accepted (e.g. on the privacy policy).

BUG=713590
Review-Url: https://codereview.chromium.org/2827333004
Cr-Commit-Position: refs/heads/master@{#466548}
Committed: https://chromium.googlesource.com/chromium/src/+/2ae9cf3f8288419c4985e4543bcd07ebf65bfd21

[benwells, 2017-04-21 07:20:37]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 07:20:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 08:33:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 08:33:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[benwells, 2017-04-21 10:54:16]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 10:54:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 12:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 12:25:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[benwells, 2017-04-21 13:36:06]

More test

[benwells, 2017-04-21 13:36:08]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 13:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 14:14:21]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-04-21 21:40:56]

Description was changed from

==========
Don't show the search geolocation disclosure until eula accepted

Letting thedisclosure be shown before this means it will come up on the
privacy policy, which breaks the flow.

BUG=713590
==========

to

==========
Don't enable the DSE geolocation setting until EULA accepted

This does two things. Firstly it prevents the DSE getting opt-out access to the
geolocation API before the EULA is accepted. Secondly, it prevents the search
geolocation disclosure from being shown before the EULA is accepted (e.g. on the
privacy policy).

BUG=713590
==========

[benwells, 2017-04-21 21:40:56]

benwells@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2017-04-21 21:44:00]

lgtm

[benwells, 2017-04-22 08:14:28]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2017-04-22 08:14:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 19:26:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492848868793090,
"parent_rev": "91fb567c1c698315b41306004ff0be0ecf8510d7", "commit_rev":
"2ae9cf3f8288419c4985e4543bcd07ebf65bfd21"}

[commit-bot: I haz the power, 2017-04-22 19:26:41]

Description was changed from

==========
Don't enable the DSE geolocation setting until EULA accepted

This does two things. Firstly it prevents the DSE getting opt-out access to the
geolocation API before the EULA is accepted. Secondly, it prevents the search
geolocation disclosure from being shown before the EULA is accepted (e.g. on the
privacy policy).

BUG=713590
==========

to

==========
Don't enable the DSE geolocation setting until EULA accepted

This does two things. Firstly it prevents the DSE getting opt-out access to the
geolocation API before the EULA is accepted. Secondly, it prevents the search
geolocation disclosure from being shown before the EULA is accepted (e.g. on the
privacy policy).

BUG=713590

Review-Url: https://codereview.chromium.org/2827333004
Cr-Commit-Position: refs/heads/master@{#466548}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ae9cf3f8288419c4985e4543bcd...
==========

[commit-bot: I haz the power, 2017-04-22 19:26:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2ae9cf3f8288419c4985e4543bcd...