Render 0px broken images correctly in quirks mode

Render 0px broken images correctly in quirks mode

Even if an image is smaller than the broken image icon it still needs to
render as a replaced element per https://html.spec.whatwg.org/multipage/rendering.html#images-3.
So do that, but ensure the broken image icon is hidden and don't render
it with a border or any other decoration.

BUG=715535
Review-Url: https://codereview.chromium.org/2853733004
Cr-Commit-Position: refs/heads/master@{#469479}
Committed: https://chromium.googlesource.com/chromium/src/+/2e3e1972ebbfdcbde70ef7c33c98169641e3f335

[rhogan, 2017-05-01 16:03:58]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 16:04:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 18:12:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rhogan, 2017-05-01 21:02:18]

Description was changed from

==========
Render 0px broken images correctly in quirks mode

BUG=715535
==========

to

==========
Render 0px broken images correctly in quirks mode

Even if an image is smaller than the broken image icon it still needs to
render as a replaced element per
https://html.spec.whatwg.org/multipage/rendering.html#images-3.
So do that, but ensure the broken image icon is hidden and don't render
it with a border or any other decoration.

BUG=715535
==========

[rhogan, 2017-05-01 21:02:36]

robhogan@gmail.com changed reviewers:
+ pdr@chromium.org

[pdr., 2017-05-03 21:05:28]

Overall looks good but I don't understand why the 2nd 1) dot moves in
rendering-broken-1px-images-expected.png. Do you know why?

[rhogan, 2017-05-03 21:06:58]

On 2017/05/03 at 21:05:28, pdr wrote:
> Overall looks good but I don't understand why the 2nd 1) dot moves in
rendering-broken-1px-images-expected.png. Do you know why?

Because I'm now rendering it as block flow rather than inline, so it doesn't get
baseline-aligned anymore by default.

[pdr., 2017-05-03 21:09:05]

LGTM

[rhogan, 2017-05-04 19:56:18]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2017-05-04 19:56:19]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2853733004/#ps60001
(title: "Render 0px broken images correctly in quirks mode")

[commit-bot: I haz the power, 2017-05-04 19:56:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 21:35:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493927778872960,
"parent_rev": "c9ef836bccf4a19fde92b42f6d68e8895f0a1a49", "commit_rev":
"2e3e1972ebbfdcbde70ef7c33c98169641e3f335"}

[commit-bot: I haz the power, 2017-05-04 21:35:49]

Description was changed from

==========
Render 0px broken images correctly in quirks mode

Even if an image is smaller than the broken image icon it still needs to
render as a replaced element per
https://html.spec.whatwg.org/multipage/rendering.html#images-3.
So do that, but ensure the broken image icon is hidden and don't render
it with a border or any other decoration.

BUG=715535
==========

to

==========
Render 0px broken images correctly in quirks mode

Even if an image is smaller than the broken image icon it still needs to
render as a replaced element per
https://html.spec.whatwg.org/multipage/rendering.html#images-3.
So do that, but ensure the broken image icon is hidden and don't render
it with a border or any other decoration.

BUG=715535

Review-Url: https://codereview.chromium.org/2853733004
Cr-Commit-Position: refs/heads/master@{#469479}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e3e1972ebbfdcbde70ef7c33c98...
==========

[commit-bot: I haz the power, 2017-05-04 21:35:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2e3e1972ebbfdcbde70ef7c33c98...