Render 0px broken images correctly in quirks mode

third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/HTMLImageFallbackHelper.h"
 
 #include "core/HTMLNames.h"
 #include "core/InputTypeNames.h"
 #include "core/dom/ElementRareData.h"
 #include "core/dom/Text.h"
@@ skipping 83 matching lines @@
     }
   }
 
   bool image_has_intrinsic_dimensions =
       new_style->Width().IsSpecifiedOrIntrinsic() &&
       new_style->Height().IsSpecifiedOrIntrinsic();
   bool image_has_no_alt_attribute = ToHTMLElement(element).AltText().IsNull();
   bool treat_as_replaced =
       image_has_intrinsic_dimensions &&
       (element.GetDocument().InQuirksMode() || image_has_no_alt_attribute);
-  // 16px for the image and 2px for its top/left border/padding offset.
-  int pixels_for_alt_image = 18;
-  if (treat_as_replaced &&
-      !ImageSmallerThanAltImage(pixels_for_alt_image, new_style->Width(),
-                                new_style->Height())) {
+  if (treat_as_replaced) {
     // https://html.spec.whatwg.org/multipage/rendering.html#images-3:
     // "If the element does not represent an image, but the element already has
     // intrinsic dimensions (e.g. from the dimension attributes or CSS rules),
     // and either: the user agent has reason to believe that the image will
     // become available and be rendered in due course, or the element has no alt
     // attribute, or the Document is in quirks mode The user agent is expected
     // to treat the element as a replaced element whose content is the text that
     // the element represents, if any."
     place_holder->SetInlineStyleProperty(CSSPropertyOverflow, CSSValueHidden);
     place_holder->SetInlineStyleProperty(CSSPropertyDisplay,
                                          CSSValueInlineBlock);
-    place_holder->SetInlineStyleProperty(CSSPropertyBorderWidth, 1,
-                                         CSSPrimitiveValue::UnitType::kPixels);
-    place_holder->SetInlineStyleProperty(CSSPropertyBorderStyle, CSSValueSolid);
-    place_holder->SetInlineStyleProperty(CSSPropertyBorderColor,
-                                         CSSValueSilver);
-    place_holder->SetInlineStyleProperty(CSSPropertyPadding, 1,
-                                         CSSPrimitiveValue::UnitType::kPixels);
-    place_holder->SetInlineStyleProperty(CSSPropertyBoxSizing,
-                                         CSSValueBorderBox);
     CSSPrimitiveValue::UnitType unit =
         new_style->Height().IsPercent()
             ? CSSPrimitiveValue::UnitType::kPercentage
             : CSSPrimitiveValue::UnitType::kPixels;
     place_holder->SetInlineStyleProperty(CSSPropertyHeight,
                                          new_style->Height().Value(), unit);
     place_holder->SetInlineStyleProperty(CSSPropertyWidth,
                                          new_style->Width().Value(), unit);
-    broken_image->SetInlineStyleProperty(CSSPropertyDisplay, CSSValueInline);
-    // Make sure the broken image icon appears on the appropriate side of the
-    // image for the element's writing direction.
-    broken_image->SetInlineStyleProperty(
-        CSSPropertyFloat,
-        AtomicString(new_style->Direction() == TextDirection::kLtr ? "left"
-                                                                   : "right"));
+
+    // 16px for the image and 2px for its top/left border/padding offset.
+    int pixels_for_alt_image = 18;
+    if (ImageSmallerThanAltImage(pixels_for_alt_image, new_style->Width(),
+                                 new_style->Height())) {
+      broken_image->SetInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
+    } else {
+      place_holder->SetInlineStyleProperty(
+          CSSPropertyBorderWidth, 1, CSSPrimitiveValue::UnitType::kPixels);
+      place_holder->SetInlineStyleProperty(CSSPropertyBorderStyle,
+                                           CSSValueSolid);
+      place_holder->SetInlineStyleProperty(CSSPropertyBorderColor,
+                                           CSSValueSilver);
+      place_holder->SetInlineStyleProperty(
+          CSSPropertyPadding, 1, CSSPrimitiveValue::UnitType::kPixels);
+      place_holder->SetInlineStyleProperty(CSSPropertyBoxSizing,
+                                           CSSValueBorderBox);
+      broken_image->SetInlineStyleProperty(CSSPropertyDisplay, CSSValueInline);
+      // Make sure the broken image icon appears on the appropriate side of the
+      // image for the element's writing direction.
+      broken_image->SetInlineStyleProperty(
+          CSSPropertyFloat,
+          AtomicString(new_style->Direction() == TextDirection::kLtr
+                           ? "left"
+                           : "right"));
+    }
   } else {
     // "If the element is an img element that represents nothing and the user
     // agent does not expect this to change the user agent is expected to treat
     // the element as an empty inline element."
     //  - We achieve this by hiding the broken image so that the span is empty.
     // "If the element is an img element that represents some text and the user
     // agent does not expect this to change the user agent is expected to treat
     // the element as a non-replaced phrasing element whose content is the text,
     // optionally with an icon indicating that an image is missing, so that the
     // user can request the image be displayed or investigate why it is not
     // rendering."
     //  - We opt not to display an icon, like Firefox.
-    if (!treat_as_replaced && new_style->Display() == EDisplay::kInline) {
+    if (new_style->Display() == EDisplay::kInline) {
       new_style->SetWidth(Length());
       new_style->SetHeight(Length());
     }
     broken_image->SetInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
   }
 
   return new_style;
 }
 
 }  // namespace blink