Add unit test to clean_caches()

Add unit test to clean_caches()

- Add unit test to ensure clean_caches() work.
- Make trim parameter explicit.
- Change Cache.trim() to return the number of items trimmed.

BUG=717716
R=nodir@chromium.org

Review-Url: https://codereview.chromium.org/2853413002
Committed: https://github.com/luci/luci-py/commit/83b611c26b82951c2e435da873c9105c245aaf6e

[M-A Ruel, 2017-05-03 21:09:39]

Description was changed from

==========
Improve cache trimming coherency

Add unit test to ensure clean_caches() work.
Make trim parameter explicit.

BUG=717716
R=vadimsh@chromium.org
==========

to

==========
Add unit test to clean_caches()

- Add unit test to ensure clean_caches() work.
- Make trim parameter explicit.
- Change Cache.trim() to return the number of items trimmed.

BUG=717716
R=nodir@chromium.org
==========

[M-A Ruel, 2017-05-03 21:09:51]

Description was changed from

==========
Add unit test to clean_caches()

- Add unit test to ensure clean_caches() work.
- Make trim parameter explicit.
- Change Cache.trim() to return the number of items trimmed.

BUG=717716
R=nodir@chromium.org
==========

to

==========
Add unit test to clean_caches()

- Add unit test to ensure clean_caches() work.
- Make trim parameter explicit.
- Change Cache.trim() to return the number of items trimmed.

BUG=717716
R=nodir@chromium.org
==========

[M-A Ruel, 2017-05-03 21:09:52]

maruel@chromium.org changed reviewers:
+ nodir@chromium.org
- vadimsh@chromium.org

[M-A Ruel, 2017-05-03 21:09:58]

Patchset #1 (id:1) has been deleted

[M-A Ruel, 2017-05-03 21:15:52]

Patchset #1 (id:20001) has been deleted

[M-A Ruel, 2017-05-03 21:19:39]

Patchset #1 (id:40001) has been deleted

[M-A Ruel, 2017-05-03 21:19:43]

This still doesn't explain the stale named caches that weren't deleted but this
documents better the current misbehavior.

[nodir, 2017-05-04 07:34:42]

lgtm

https://codereview.chromium.org/2853413002/diff/60001/client/tests/run_isolat...
File client/tests/run_isolated_test.py (right):

https://codereview.chromium.org/2853413002/diff/60001/client/tests/run_isolat...
client/tests/run_isolated_test.py:64: relpath = p[len(path):].lstrip(os.sep)
why not os.path.relpath?

https://codereview.chromium.org/2853413002/diff/60001/client/tests/run_isolat...
client/tests/run_isolated_test.py:655: parser, options)
why isolate_cache and named_cache_manager are re-created?

[M-A Ruel, 2017-05-04 16:00:56]

https://codereview.chromium.org/2853413002/diff/60001/client/tests/run_isolat...
File client/tests/run_isolated_test.py (right):

https://codereview.chromium.org/2853413002/diff/60001/client/tests/run_isolat...
client/tests/run_isolated_test.py:64: relpath = p[len(path):].lstrip(os.sep)
On 2017/05/04 07:34:41, nodir wrote:
> why not os.path.relpath?

Done.

https://codereview.chromium.org/2853413002/diff/60001/client/tests/run_isolat...
client/tests/run_isolated_test.py:655: parser, options)
On 2017/05/04 07:34:41, nodir wrote:
> why isolate_cache and named_cache_manager are re-created?

I wanted to be sure to flush the internal state.

[M-A Ruel, 2017-05-04 16:00:59]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2017-05-04 16:01:00]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2853413002/#ps80001
(title: "os.path.relpath")

[commit-bot: I haz the power, 2017-05-04 16:01:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 16:03:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493913659829900,
"parent_rev": "82f6e8fa773fdb9ab378130c17bea9df5637a85c", "commit_rev":
"83b611c26b82951c2e435da873c9105c245aaf6e"}

[commit-bot: I haz the power, 2017-05-04 16:03:52]

Description was changed from

==========
Add unit test to clean_caches()

- Add unit test to ensure clean_caches() work.
- Make trim parameter explicit.
- Change Cache.trim() to return the number of items trimmed.

BUG=717716
R=nodir@chromium.org
==========

to

==========
Add unit test to clean_caches()

- Add unit test to ensure clean_caches() work.
- Make trim parameter explicit.
- Change Cache.trim() to return the number of items trimmed.

BUG=717716
R=nodir@chromium.org

Review-Url: https://codereview.chromium.org/2853413002
Committed:
https://github.com/luci/luci-py/commit/83b611c26b82951c2e435da873c9105c245aaf6e
==========

[commit-bot: I haz the power, 2017-05-04 16:03:54]

Committed patchset #2 (id:80001) as
https://github.com/luci/luci-py/commit/83b611c26b82951c2e435da873c9105c245aaf6e