client/cipd.py - Issue 2853413002: Add unit test to clean_caches()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/cipd.py

Issue 2853413002: Add unit test to clean_caches() (Closed)

Patch Set: os.path.relpath Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/cipd.py

diff --git a/client/cipd.py b/client/cipd.py

index 927ec594354790a93fbc22c418c1af17fda29daf..6fb16324368a20f75f121cf4ecdbe24c402ca925 100644

--- a/client/cipd.py

+++ b/client/cipd.py

@@ -409,7 +409,8 @@ def get_client(service_url, package_name, version, cache_dir, timeout=None):

version_cache = isolateserver.DiskCache(

unicode(os.path.join(cache_dir, 'versions')),

isolateserver.CachePolicies(0, 0, 300),

- hashlib.sha1)

+ hashlib.sha1,

+ trim=True)

with version_cache:

version_cache.cleanup()

# Convert |version| to a string that may be used as a filename in disk

@@ -431,7 +432,8 @@ def get_client(service_url, package_name, version, cache_dir, timeout=None):

instance_cache = isolateserver.DiskCache(

unicode(os.path.join(cache_dir, 'clients')),

isolateserver.CachePolicies(0, 0, 5),

- hashlib.sha1)

+ hashlib.sha1,

+ trim=True)

with instance_cache:

instance_cache.cleanup()

if instance_id not in instance_cache:

« no previous file with comments | « no previous file | client/isolateserver.py » ('j') | no next file with comments »