Avoid Showing rotation change notification when source is accelerometer

Avoid Showing rotation change notification when source is accelerometer

BUG=717252
TEST=Manually rotate device with accelerometer and observe there's no notification

Review-Url: https://codereview.chromium.org/2853113005
Cr-Commit-Position: refs/heads/master@{#469058}
Committed: https://chromium.googlesource.com/chromium/src/+/31b81d4cf8b6a063391839816c82fc61c8272e53

[afakhry, 2017-05-02 01:42:30]

afakhry@chromium.org changed reviewers:
+ oshima@chromium.org

[afakhry, 2017-05-02 01:42:30]

Oshima-san, please take a look. Thank you!

[oshima, 2017-05-02 14:17:48]

can you add a unit test?

[afakhry, 2017-05-03 04:48:39]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 04:48:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-05-03 04:49:34]

On 2017/05/02 14:17:48, oshima wrote:
> can you add a unit test?

Done. Please take a look.

[commit-bot: I haz the power, 2017-05-03 05:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 05:36:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2017-05-03 12:54:56]

https://codereview.chromium.org/2853113005/diff/20001/ash/system/screen_layou...
File ash/system/screen_layout_observer_unittest.cc (right):

https://codereview.chromium.org/2853113005/diff/20001/ash/system/screen_layou...
ash/system/screen_layout_observer_unittest.cc:452:
display_manager()->UpdateInternalManagedDisplayModeListForTest();
Can you use DisplayManager::SetDisplayRotation ?

[afakhry, 2017-05-03 16:02:19]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[afakhry, 2017-05-03 16:02:41]

https://codereview.chromium.org/2853113005/diff/20001/ash/system/screen_layou...
File ash/system/screen_layout_observer_unittest.cc (right):

https://codereview.chromium.org/2853113005/diff/20001/ash/system/screen_layou...
ash/system/screen_layout_observer_unittest.cc:452:
display_manager()->UpdateInternalManagedDisplayModeListForTest();
On 2017/05/03 12:54:56, oshima wrote:
> Can you use DisplayManager::SetDisplayRotation ?

Done.

[commit-bot: I haz the power, 2017-05-03 16:02:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima_google, 2017-05-03 16:19:01]

oshima@google.com changed reviewers:
+ oshima@google.com

[oshima_google, 2017-05-03 16:19:02]

lgtm

[oshima, 2017-05-03 16:27:26]

lgtm

[commit-bot: I haz the power, 2017-05-03 17:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 17:07:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[afakhry, 2017-05-03 17:45:03]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-05-03 17:45:03]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@google.com,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2853113005/#ps60001
(title: "Don't run on mushrome")

[commit-bot: I haz the power, 2017-05-03 17:45:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 18:57:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493833503094510,
"parent_rev": "ddffea091f64d790fa6b2f40a82e19b39b1768c9", "commit_rev":
"31b81d4cf8b6a063391839816c82fc61c8272e53"}

[commit-bot: I haz the power, 2017-05-03 18:57:59]

Description was changed from

==========
Avoid Showing rotation change notification when source is accelerometer

BUG=717252
TEST=Manually rotate device with accelerometer and observe there's no
notification
==========

to

==========
Avoid Showing rotation change notification when source is accelerometer

BUG=717252
TEST=Manually rotate device with accelerometer and observe there's no
notification

Review-Url: https://codereview.chromium.org/2853113005
Cr-Commit-Position: refs/heads/master@{#469058}
Committed:
https://chromium.googlesource.com/chromium/src/+/31b81d4cf8b6a063391839816c82...
==========

[commit-bot: I haz the power, 2017-05-03 18:58:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/31b81d4cf8b6a063391839816c82...