Avoid Showing rotation change notification when source is accelerometer

ash/system/screen_layout_observer_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/screen_layout_observer.h"
 
 #include "ash/shell.h"
 #include "ash/strings/grit/ash_strings.h"
 #include "ash/system/devicetype_utils.h"
 #include "ash/system/tray/system_tray.h"
@@ skipping 412 matching lines @@
                               display::DisplayPlacement::LEFT, 0);
   display_manager()->SetLayoutForCurrentDisplays(builder.Build());
   EXPECT_TRUE(GetDisplayNotificationText().empty());
 
   // Close the lid. We go to docked mode, but we show no notifications.
   UpdateDisplay("400x400");
   EXPECT_TRUE(GetDisplayNotificationText().empty());
   EXPECT_TRUE(GetDisplayNotificationAdditionalText().empty());
 }
 
+// Tests that rotation notifications are only shown when the rotation source is
+// a user action. The accelerometer source nevber produces any notifications.
+TEST_F(ScreenLayoutObserverTest, RotationNotification) {
+  Shell::Get()->screen_layout_observer()->set_show_notifications_for_testing(
+      true);
+  UpdateDisplay("400x400");
+  const int64_t primary_id =
+      display_manager()->GetPrimaryDisplayCandidate().id();
+  display::ManagedDisplayInfo display_info(primary_id, "" /* name */,
+                                           true /* has_overscan */);
+  display::DisplayInfoList display_info_list;
+  display_info_list.emplace_back(display_info);
+
+  // The accelerometer source.
+  display_info_list.back().Copy(display_manager()->GetDisplayInfo(primary_id));
+  display_info_list.back().SetRotation(
+      display::Display::ROTATE_90,
+      display::Display::ROTATION_SOURCE_ACCELEROMETER);
+  display_manager()->OnNativeDisplaysChanged(display_info_list);
+  display_manager()->UpdateInternalManagedDisplayModeListForTest();

[oshima, 2017/05/03 12:54:56]

Can you use DisplayManager::SetDisplayRotation ?

[afakhry, 2017/05/03 16:02:41]

Done.

+  EXPECT_TRUE(GetDisplayNotificationText().empty());
+  EXPECT_TRUE(GetDisplayNotificationAdditionalText().empty());
+
+  // The user source.
+  display_info_list.back().SetRotation(display::Display::ROTATE_180,
+                                       display::Display::ROTATION_SOURCE_USER);
+  display_manager()->OnNativeDisplaysChanged(display_info_list);
+  display_manager()->UpdateInternalManagedDisplayModeListForTest();
+  EXPECT_EQ(l10n_util::GetStringFUTF16(
+                IDS_ASH_STATUS_TRAY_DISPLAY_ROTATED, GetFirstDisplayName(),
+                l10n_util::GetStringUTF16(
+                    IDS_ASH_STATUS_TRAY_DISPLAY_ORIENTATION_180)),
+            GetDisplayNotificationAdditionalText());
+  EXPECT_TRUE(GetDisplayNotificationText().empty());
+}
+
 }  // namespace ash