Issue 2853063003: MD Settings: mergeable "View password" button fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2853063003: MD Settings: mergeable "View password" button fix (Closed)

Created:
3 years, 7 months ago by Dan Beam

Modified:
3 years, 7 months ago

Reviewers:
hcarmona

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

MD Settings: mergeable "View password" button fix R=hcarmona@chromium.org BUG=715866 Review-Url: https://codereview.chromium.org/2848983002 Cr-Commit-Position: refs/heads/master@{#468171} (cherry picked from commit 11b44dd3ae59e1116acc9358a1807ccdf29a1359) Review-Url: https://codereview.chromium.org/2853063003 . Cr-Commit-Position: refs/branch-heads/3071@{#332} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/6b0d321f91799deaee17f021aac62967c4249d03

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Dan Beam

3 years, 7 months ago (2017-05-01 19:02:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6b0d321f91799deaee17f021aac62967c4249d03.