Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 2848983002: MD Settings: mergeable "View password" button fix (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
stevenjb, hcarmona
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: mergeable "View password" button fix R=hcarmona@chromium.org BUG=715866 Review-Url: https://codereview.chromium.org/2848983002 Cr-Commit-Position: refs/heads/master@{#468171} Committed: https://chromium.googlesource.com/chromium/src/+/11b44dd3ae59e1116acc9358a1807ccdf29a1359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Dan Beam
3 years, 7 months ago (2017-04-28 20:11:12 UTC) #1
hcarmona
lgtm
3 years, 7 months ago (2017-04-28 21:04:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848983002/1
3 years, 7 months ago (2017-04-28 22:36:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/423785)
3 years, 7 months ago (2017-04-28 22:44:05 UTC) #10
stevenjb
RS lgtm
3 years, 7 months ago (2017-04-28 23:01:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848983002/1
3 years, 7 months ago (2017-04-28 23:03:36 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 23:09:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11b44dd3ae59e1116acc9358a180...

Powered by Google App Engine
This is Rietveld 408576698