net: Unbreak component build on Linux.

net: Unbreak component build on Linux.

This is happening when running the following command line:

$ gn gen out/Debug --args='is_component_build=true'
ERROR at //net/third_party/nss/ssl/BUILD.gn:122:18: Item not found
    configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
                     ^--------------------------------------------
You were trying to remove "//build/config/gcc:symbol_visibility_hidden"
from the list but it wasn't there.

BUG=None
TEST=above
R=brettw@chromium.org,wtc@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271294

[brettw, 2014-05-16 17:01:57]

lgtm

https://codereview.chromium.org/285293009/diff/1/net/third_party/nss/ssl/BUIL...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/285293009/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:81: configs -= [
"//build/config/gcc:symbol_visibility_hidden" ]
To match the GYP behavior, we should also change this line to:
  if (component_mode == "shared_library") {
    configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
  }

[tfarina, 2014-05-16 17:35:16]

https://codereview.chromium.org/285293009/diff/1/net/third_party/nss/ssl/BUIL...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/285293009/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:81: configs -= [
"//build/config/gcc:symbol_visibility_hidden" ]
On 2014/05/16 17:01:57, brettw wrote:
> To match the GYP behavior, we should also change this line to:
>   if (component_mode == "shared_library") {
>     configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
>   }

Done.

[wtc, 2014-05-16 23:12:08]

Patch set 2 LGTM.

https://codereview.chromium.org/285293009/diff/20001/net/third_party/nss/ssl/...
File net/third_party/nss/ssl/BUILD.gn (left):

https://codereview.chromium.org/285293009/diff/20001/net/third_party/nss/ssl/...
net/third_party/nss/ssl/BUILD.gn:123: }

Does Mac, iOS, or Android need this?

[tfarina, 2014-05-16 23:23:37]

https://codereview.chromium.org/285293009/diff/20001/net/third_party/nss/ssl/...
File net/third_party/nss/ssl/BUILD.gn (left):

https://codereview.chromium.org/285293009/diff/20001/net/third_party/nss/ssl/...
net/third_party/nss/ssl/BUILD.gn:123: }
On 2014/05/16 23:12:07, wtc wrote:
> 
> Does Mac, iOS, or Android need this?
That is a good question. 

Currently we don't build //net on Android, so it won't be an issue until we
enable it there.

For Mac and iOS we don't have bots for them right now.

I think Brett builds on Mac, so if this proves to be an issue, he might be able
to fix it. Note that I'm not happy to break anything intentionally. It's just
not my fault as I don't have a Mac to build it there.

But we are good for now with this as it passes the current set of configurations
in the trybots.

[tfarina, 2014-05-18 05:26:20]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-18 05:26:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/285293009/20001

[commit-bot: I haz the power, 2014-05-18 14:17:42]

Change committed as 271294