Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: net/third_party/nss/ssl/BUILD.gn

Issue 285293009: net: Unbreak component build on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: check component_mode Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/third_party/nss/ssl/BUILD.gn
diff --git a/net/third_party/nss/ssl/BUILD.gn b/net/third_party/nss/ssl/BUILD.gn
index ae3d2c38a296d0758d5acd4400165d469ad52dd6..7f3ad2ca834640aba399ee7ef15520ad2178cbbf 100644
--- a/net/third_party/nss/ssl/BUILD.gn
+++ b/net/third_party/nss/ssl/BUILD.gn
@@ -78,7 +78,10 @@ component("libssl") {
]
sources += [ "exports_win.def" ]
} else if (is_linux) {
- configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
+ if (component_mode == "shared_library") {
+ configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
+ }
+
libs = [ "dl" ]
include_dirs = [ "bodge" ]
@@ -118,10 +121,6 @@ component("libssl") {
forward_dependent_configs_from = deps
}
- if (!is_win && component_mode == "shared_library") {
- configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
- }
wtc 2014/05/16 23:12:07 Does Mac, iOS, or Android need this?
tfarina 2014/05/16 23:23:37 That is a good question. Currently we don't buil
-
if (is_clang) {
cflags += [
# See http://crbug.com/138571#c8. In short, sslsecur.c picks up the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698