net: Unbreak component build on Linux.

net/third_party/nss/ssl/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 config("ssl_config") {
   include_dirs = [ "." ]
 
   if (is_mac || is_win) {
     defines = [ "NSS_PLATFORM_CLIENT_AUTH" ]
   }
@@ skipping 60 matching lines @@
 
   if (is_win) {
     cflags += [ "/wd4267" ]  # Disable warning: Conversion from size_t to 'type'.
 
     sources -= [
       "unix_err.c",
       "unix_err.h",
     ]
     sources += [ "exports_win.def" ]
   } else if (is_linux) {
-    configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
+    if (component_mode == "shared_library") {
+      configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
+    }
+
     libs = [ "dl" ]
 
     include_dirs = [ "bodge" ]
 
     # Must be after ssl_config since we want our SSL headers to take
     # precedence.
     direct_dependent_configs += [
       "//third_party/nss:system_nss_no_ssl_config"
     ]
   } else if (is_mac) {
@@ skipping 19 matching lines @@
     sources -= [
       "bodge/secitem_array.c",
     ]
     deps = [
       "//third_party/nss:nspr",
       "//third_party/nss:nss",
     ]
     forward_dependent_configs_from = deps
   }
 
-  if (!is_win && component_mode == "shared_library") {
-    configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
-  }

[wtc, 2014/05/16 23:12:07]

Does Mac, iOS, or Android need this?

[tfarina, 2014/05/16 23:23:37]

That is a good question. 

Currently we don't build //net on Android, so it won't be an issue until we
enable it there.

For Mac and iOS we don't have bots for them right now.

I think Brett builds on Mac, so if this proves to be an issue, he might be able
to fix it. Note that I'm not happy to break anything intentionally. It's just
not my fault as I don't have a Mac to build it there.

But we are good for now with this as it passes the current set of configurations
in the trybots.

-
   if (is_clang) {
     cflags += [
       # See http://crbug.com/138571#c8. In short, sslsecur.c picks up the
       # system's cert.h because cert.h isn't in chromium's repo.
       "-Wno-incompatible-pointer-types",
 
       # There is a broken header guard in /usr/include/nss/secmod.h:
       # https://bugzilla.mozilla.org/show_bug.cgi?id=884072
       "-Wno-header-guard",
     ]
   }
 
   if (is_debug) {
     defines += [ "DEBUG" ]
   }
 }