Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl

Issue 2852823002: Rename KeyLock to KeyboardLock and return enum from IPC (Closed)
Patch Set: Remove KeyboardLockRequestResult::FAILURE; it is not used by Chrome. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl
diff --git a/third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl b/third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl
index 580467e0d6ee9fb2478cb76e9e21b3075984498a..b579df0acf59d33cef0072c37abcbbecf49d542d 100644
--- a/third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl
+++ b/third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl
@@ -7,17 +7,17 @@
// 1. "System" should be removed from both the function names: these functions
// are not for system keys or key combinations only.
// See https://github.com/w3c/keyboard-lock/issues/6
-// 2. Returns Promise<void> from requestKeyLock() function: user agents can
+// 2. Returns Promise<void> from requestKeyboardLock() function: user agents can
// decline the request, and web page can get a notification once the
// requested keys should be received.
// See https://github.com/w3c/keyboard-lock/issues/7
-// 3. The parameter of requestKeyLock() should be
+// 3. The parameter of requestKeyboardLock() should be
// optional sequence<DOMString> keyCodes = []
// See https://github.com/w3c/keyboard-lock/issues/21
-// 4. cancelKeyLock() function is implicitly called whenever the unloading
+// 4. cancelKeyboardLock() function is implicitly called whenever the unloading
// document cleanup steps run with a document.
// See https://github.com/w3c/keyboard-lock/issues/22
partial interface Navigator {
- [SecureContext, RuntimeEnabled=KeyboardLock, CallWith=ScriptState] Promise<void> requestKeyLock(optional sequence<DOMString> keyCodes = []);
- [SecureContext, RuntimeEnabled=KeyboardLock] void cancelKeyLock();
+ [SecureContext, RuntimeEnabled=KeyboardLock, CallWith=ScriptState] Promise<void> requestKeyboardLock(optional sequence<DOMString> keyCodes = []);
+ [SecureContext, RuntimeEnabled=KeyboardLock] void cancelKeyboardLock();
};

Powered by Google App Engine
This is Rietveld 408576698