Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2852733002: Duplicate -Move DevTools out of ash and turn it to a component. (Closed)

Created:
3 years, 7 months ago by thanhph
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP: Move DevTools out of ash and turn it to a component. This entails removing AshTestbase dependency, use ViewTestBase and create appropriate window/widget/view trees for DevTools unit test. BUG=701835

Patch Set 1 : rebase #

Patch Set 2 : . #

Patch Set 3 : Use ViewTestBase for unittest. #

Patch Set 4 : move unittest to ui/views #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -2495 lines) Patch
M ash/BUILD.gn View 3 chunks +1 line, -14 lines 0 comments Download
D ash/devtools/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ash/devtools/ash_devtools_css_agent.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ash/devtools/ash_devtools_css_agent.cc View 1 chunk +0 lines, -210 lines 0 comments Download
D ash/devtools/ash_devtools_dom_agent.h View 1 1 chunk +0 lines, -110 lines 0 comments Download
D ash/devtools/ash_devtools_dom_agent.cc View 1 1 chunk +0 lines, -401 lines 0 comments Download
D ash/devtools/ash_devtools_unittest.cc View 1 1 chunk +0 lines, -828 lines 0 comments Download
D ash/devtools/ui_element.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D ash/devtools/ui_element.cc View 1 1 chunk +0 lines, -78 lines 0 comments Download
D ash/devtools/ui_element_delegate.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
D ash/devtools/view_element.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ash/devtools/view_element.cc View 1 1 chunk +0 lines, -93 lines 0 comments Download
D ash/devtools/widget_element.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ash/devtools/widget_element.cc View 1 1 chunk +0 lines, -77 lines 0 comments Download
D ash/devtools/window_element.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ash/devtools/window_element.cc View 1 1 chunk +0 lines, -110 lines 0 comments Download
M ash/shell.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/ui_devtools/BUILD.gn View 1 2 3 3 chunks +36 lines, -0 lines 0 comments Download
A components/ui_devtools/devtools/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + components/ui_devtools/devtools/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/ui_devtools/devtools/ui_devtools_css_agent.h View 3 chunks +13 lines, -14 lines 0 comments Download
A + components/ui_devtools/devtools/ui_devtools_css_agent.cc View 7 chunks +19 lines, -20 lines 0 comments Download
A + components/ui_devtools/devtools/ui_devtools_dom_agent.h View 1 5 chunks +15 lines, -16 lines 0 comments Download
A + components/ui_devtools/devtools/ui_devtools_dom_agent.cc View 1 14 chunks +41 lines, -38 lines 0 comments Download
A + components/ui_devtools/devtools/ui_devtools_unittest.cc View 1 2 3 21 chunks +117 lines, -77 lines 0 comments Download
A + components/ui_devtools/devtools/ui_element.h View 1 3 chunks +6 lines, -7 lines 0 comments Download
A + components/ui_devtools/devtools/ui_element.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + components/ui_devtools/devtools/ui_element_delegate.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
A + components/ui_devtools/devtools/view_element.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + components/ui_devtools/devtools/view_element.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/ui_devtools/devtools/widget_element.h View 2 chunks +9 lines, -10 lines 0 comments Download
A + components/ui_devtools/devtools/widget_element.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/ui_devtools/devtools/window_element.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + components/ui_devtools/devtools/window_element.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 2865713003 Patch 40001

Messages

Total messages: 51 (51 generated)
thanhph
Description was changed from ========== Move DevTools out of ash and turn it to a ...
3 years, 7 months ago (2017-04-28 16:11:58 UTC) #1
thanhph
Patchset #1 (id:1) has been deleted
3 years, 7 months ago (2017-04-28 16:13:51 UTC) #2
thanhph
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-28 17:24:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852733002/60001
3 years, 7 months ago (2017-04-28 17:25:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-28 17:31:08 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/258963)
3 years, 7 months ago (2017-04-28 17:31:09 UTC) #6
thanhph
Patchset #2 (id:40001) has been deleted
3 years, 7 months ago (2017-05-01 13:18:26 UTC) #7
thanhph
Patchset #1 (id:20001) has been deleted
3 years, 7 months ago (2017-05-01 13:18:39 UTC) #8
thanhph
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-01 14:16:02 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852733002/80001
3 years, 7 months ago (2017-05-01 14:16:06 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-01 14:19:57 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/129675) cast_shell_android on ...
3 years, 7 months ago (2017-05-01 14:19:57 UTC) #12
thanhph
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 19:04:14 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852733002/100001
3 years, 7 months ago (2017-05-05 19:04:57 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 19:10:15 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/261895) android_clang_dbg_recipe on ...
3 years, 7 months ago (2017-05-05 19:10:17 UTC) #16
thanhph
Patchset #1 (id:60001) has been deleted
3 years, 7 months ago (2017-05-05 19:55:34 UTC) #17
thanhph
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-05 20:45:08 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852733002/220001
3 years, 7 months ago (2017-05-05 20:46:24 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-05 20:52:39 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/261987) mac_chromium_compile_dbg_ng on ...
3 years, 7 months ago (2017-05-05 20:52:40 UTC) #21
thanhph
Patchset #1 (id:80001) has been deleted
3 years, 7 months ago (2017-05-06 15:38:22 UTC) #22
thanhph
Patchset #1 (id:100001) has been deleted
3 years, 7 months ago (2017-05-06 15:38:31 UTC) #23
thanhph
Patchset #1 (id:120001) has been deleted
3 years, 7 months ago (2017-05-06 15:38:40 UTC) #24
thanhph
Patchset #1 (id:140001) has been deleted
3 years, 7 months ago (2017-05-06 15:38:47 UTC) #25
thanhph
Patchset #1 (id:160001) has been deleted
3 years, 7 months ago (2017-05-06 15:38:54 UTC) #26
thanhph
Patchset #1 (id:180001) has been deleted
3 years, 7 months ago (2017-05-06 15:39:02 UTC) #27
thanhph
Patchset #1 (id:200001) has been deleted
3 years, 7 months ago (2017-05-06 15:39:18 UTC) #28
thanhph
Patchset #1 (id:220001) has been deleted
3 years, 7 months ago (2017-05-06 15:39:27 UTC) #29
thanhph
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-06 15:49:28 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852733002/260001
3 years, 7 months ago (2017-05-06 15:49:56 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-06 15:54:28 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/133577) linux_android_rel_ng on ...
3 years, 7 months ago (2017-05-06 15:54:29 UTC) #33
thanhph
Patchset #1 (id:240001) has been deleted
3 years, 7 months ago (2017-05-08 19:09:36 UTC) #34
thanhph
Patchset #1 (id:260001) has been deleted
3 years, 7 months ago (2017-05-08 19:09:44 UTC) #35
thanhph
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 19:10:25 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852733002/280001
3 years, 7 months ago (2017-05-08 19:11:40 UTC) #37
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 19:17:20 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/263074) mac_chromium_compile_dbg_ng on ...
3 years, 7 months ago (2017-05-08 19:17:22 UTC) #39
thanhph
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-16 15:31:43 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852733002/300001
3 years, 7 months ago (2017-05-16 15:33:10 UTC) #41
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-16 15:37:29 UTC) #42
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/269991)
3 years, 7 months ago (2017-05-16 15:37:30 UTC) #43
thanhph
Description was changed from ========== WIP: Move DevTools out of ash and turn it to ...
3 years, 7 months ago (2017-05-16 17:08:55 UTC) #44
thanhph
Description was changed from ========== WIP: Move DevTools out of ash and turn it to ...
3 years, 7 months ago (2017-05-16 17:36:56 UTC) #45
thanhph
The CQ bit was checked by thanhph@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-16 17:37:38 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852733002/340001
3 years, 7 months ago (2017-05-16 17:38:25 UTC) #47
thanhph
Description was changed from ========== WIP: Move DevTools out of ash and turn it to ...
3 years, 7 months ago (2017-05-16 17:40:32 UTC) #48
thanhph
Description was changed from ========== WIP: Move DevTools out of ash and turn it to ...
3 years, 7 months ago (2017-05-16 17:41:10 UTC) #49
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-16 17:44:53 UTC) #50
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 17:44:54 UTC) #51 
Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Powered by Google App Engine
This is Rietveld 408576698