Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2085)

Unified Diff: ash/devtools/ash_devtools_css_agent.cc

Issue 2852733002: Duplicate -Move DevTools out of ash and turn it to a component. (Closed)
Patch Set: move unittest to ui/views Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/devtools/ash_devtools_css_agent.h ('k') | ash/devtools/ash_devtools_dom_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/devtools/ash_devtools_css_agent.cc
diff --git a/ash/devtools/ash_devtools_css_agent.cc b/ash/devtools/ash_devtools_css_agent.cc
deleted file mode 100644
index 90c2ed2d37a1a38a95f69655c94e7f45ceff8d74..0000000000000000000000000000000000000000
--- a/ash/devtools/ash_devtools_css_agent.cc
+++ /dev/null
@@ -1,210 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "ash/devtools/ash_devtools_css_agent.h"
-
-#include "ash/devtools/ui_element.h"
-#include "base/strings/string_split.h"
-#include "base/strings/string_util.h"
-#include "ui/aura/window.h"
-
-namespace ash {
-namespace devtools {
-namespace {
-
-using namespace ui::devtools::protocol;
-
-const char kHeight[] = "height";
-const char kWidth[] = "width";
-const char kX[] = "x";
-const char kY[] = "y";
-const char kVisibility[] = "visibility";
-
-std::unique_ptr<CSS::SourceRange> BuildDefaultSourceRange() {
- // These tell the frontend where in the stylesheet a certain style
- // is located. Since we don't have stylesheets, this is all 0.
- // We need this because CSS fields are not editable unless
- // the range is provided.
- return CSS::SourceRange::create()
- .setStartLine(0)
- .setEndLine(0)
- .setStartColumn(0)
- .setEndColumn(0)
- .build();
-}
-
-std::unique_ptr<CSS::CSSProperty> BuildCSSProperty(const std::string& name,
- int value) {
- return CSS::CSSProperty::create()
- .setRange(BuildDefaultSourceRange())
- .setName(name)
- .setValue(base::IntToString(value))
- .build();
-}
-
-std::unique_ptr<Array<CSS::CSSProperty>> BuildCSSPropertyArray(
- const gfx::Rect& bounds,
- const bool visible) {
- auto cssProperties = Array<CSS::CSSProperty>::create();
- cssProperties->addItem(BuildCSSProperty(kHeight, bounds.height()));
- cssProperties->addItem(BuildCSSProperty(kWidth, bounds.width()));
- cssProperties->addItem(BuildCSSProperty(kX, bounds.x()));
- cssProperties->addItem(BuildCSSProperty(kY, bounds.y()));
- cssProperties->addItem(BuildCSSProperty(kVisibility, visible));
- return cssProperties;
-}
-
-std::unique_ptr<CSS::CSSStyle> BuildCSSStyle(int node_id,
- const gfx::Rect& bounds,
- bool visible) {
- return CSS::CSSStyle::create()
- .setRange(BuildDefaultSourceRange())
- .setStyleSheetId(base::IntToString(node_id))
- .setCssProperties(BuildCSSPropertyArray(bounds, visible))
- .setShorthandEntries(Array<std::string>::create())
- .build();
-}
-
-ui::devtools::protocol::Response NodeNotFoundError(int node_id) {
- return ui::devtools::protocol::Response::Error(
- "Node with id=" + std::to_string(node_id) + " not found");
-}
-
-Response ParseProperties(const std::string& style_text,
- gfx::Rect* bounds,
- bool* visible) {
- std::vector<std::string> tokens = base::SplitString(
- style_text, ":;", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
- for (size_t i = 0; i < tokens.size() - 1; i += 2) {
- const std::string& property = tokens.at(i);
- int value;
- if (!base::StringToInt(tokens.at(i + 1), &value))
- return Response::Error("Unable to parse value for property=" + property);
-
- if (property == kHeight)
- bounds->set_height(std::max(0, value));
- else if (property == kWidth)
- bounds->set_width(std::max(0, value));
- else if (property == kX)
- bounds->set_x(value);
- else if (property == kY)
- bounds->set_y(value);
- else if (property == kVisibility)
- *visible = std::max(0, value) == 1;
- else
- return Response::Error("Unsupported property=" + property);
- }
- return Response::OK();
-}
-
-} // namespace
-
-AshDevToolsCSSAgent::AshDevToolsCSSAgent(AshDevToolsDOMAgent* dom_agent)
- : dom_agent_(dom_agent) {
- DCHECK(dom_agent_);
-}
-
-AshDevToolsCSSAgent::~AshDevToolsCSSAgent() {
- disable();
-}
-
-ui::devtools::protocol::Response AshDevToolsCSSAgent::enable() {
- dom_agent_->AddObserver(this);
- return ui::devtools::protocol::Response::OK();
-}
-
-ui::devtools::protocol::Response AshDevToolsCSSAgent::disable() {
- dom_agent_->RemoveObserver(this);
- return ui::devtools::protocol::Response::OK();
-}
-
-ui::devtools::protocol::Response AshDevToolsCSSAgent::getMatchedStylesForNode(
- int node_id,
- ui::devtools::protocol::Maybe<ui::devtools::protocol::CSS::CSSStyle>*
- inline_style) {
- *inline_style = GetStylesForNode(node_id);
- if (!inline_style)
- return NodeNotFoundError(node_id);
- return ui::devtools::protocol::Response::OK();
-}
-
-ui::devtools::protocol::Response AshDevToolsCSSAgent::setStyleTexts(
- std::unique_ptr<ui::devtools::protocol::Array<
- ui::devtools::protocol::CSS::StyleDeclarationEdit>> edits,
- std::unique_ptr<
- ui::devtools::protocol::Array<ui::devtools::protocol::CSS::CSSStyle>>*
- result) {
- std::unique_ptr<
- ui::devtools::protocol::Array<ui::devtools::protocol::CSS::CSSStyle>>
- updated_styles = ui::devtools::protocol::Array<
- ui::devtools::protocol::CSS::CSSStyle>::create();
- for (size_t i = 0; i < edits->length(); i++) {
- auto* edit = edits->get(i);
- int node_id;
- if (!base::StringToInt(edit->getStyleSheetId(), &node_id))
- return ui::devtools::protocol::Response::Error("Invalid node id");
-
- gfx::Rect updated_bounds;
- bool visible = false;
- if (!GetPropertiesForNodeId(node_id, &updated_bounds, &visible))
- return NodeNotFoundError(node_id);
-
- ui::devtools::protocol::Response response(
- ParseProperties(edit->getText(), &updated_bounds, &visible));
- if (!response.isSuccess())
- return response;
-
- updated_styles->addItem(BuildCSSStyle(node_id, updated_bounds, visible));
-
- if (!SetPropertiesForNodeId(node_id, updated_bounds, visible))
- return NodeNotFoundError(node_id);
- }
- *result = std::move(updated_styles);
- return ui::devtools::protocol::Response::OK();
-}
-
-void AshDevToolsCSSAgent::OnNodeBoundsChanged(int node_id) {
- InvalidateStyleSheet(node_id);
-}
-
-std::unique_ptr<ui::devtools::protocol::CSS::CSSStyle>
-AshDevToolsCSSAgent::GetStylesForNode(int node_id) {
- gfx::Rect bounds;
- bool visible = false;
- return GetPropertiesForNodeId(node_id, &bounds, &visible)
- ? BuildCSSStyle(node_id, bounds, visible)
- : nullptr;
-}
-
-void AshDevToolsCSSAgent::InvalidateStyleSheet(int node_id) {
- // The stylesheetId for each node is equivalent to its node_id (as a string).
- frontend()->styleSheetChanged(base::IntToString(node_id));
-}
-
-bool AshDevToolsCSSAgent::GetPropertiesForNodeId(int node_id,
- gfx::Rect* bounds,
- bool* visible) {
- UIElement* ui_element = dom_agent_->GetElementFromNodeId(node_id);
- if (ui_element) {
- ui_element->GetBounds(bounds);
- ui_element->GetVisible(visible);
- return true;
- }
- return false;
-}
-
-bool AshDevToolsCSSAgent::SetPropertiesForNodeId(int node_id,
- const gfx::Rect& bounds,
- bool visible) {
- UIElement* ui_element = dom_agent_->GetElementFromNodeId(node_id);
- if (ui_element) {
- ui_element->SetBounds(bounds);
- ui_element->SetVisible(visible);
- return true;
- }
- return false;
-}
-
-} // namespace devtools
-} // namespace ash
« no previous file with comments | « ash/devtools/ash_devtools_css_agent.h ('k') | ash/devtools/ash_devtools_dom_agent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698