Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2852693002: Remove DetermineIfPageSupportsInstant and all its plumbing (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
kenrb, sfiera
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, donnd+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, darin (slow to review), Jered
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DetermineIfPageSupportsInstant and all its plumbing This is part of a series of CLs to get rid of the notion of "Instant support" entirely, see https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41 BUG=627747 Review-Url: https://codereview.chromium.org/2852693002 Cr-Commit-Position: refs/heads/master@{#468624} Committed: https://chromium.googlesource.com/chromium/src/+/5bd9e2fd296b774e34d04cddfb09893525a79c04

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -165 lines) Patch
M chrome/browser/ui/search/instant_tab_unittest.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.h View 1 5 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 3 chunks +1 line, -24 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/common/instant.mojom View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/common/search/mock_searchbox.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 2 chunks +0 lines, -22 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (19 generated)
Marc Treib
One more!
3 years, 7 months ago (2017-04-28 15:52:43 UTC) #7
sfiera
LGTM
3 years, 7 months ago (2017-04-28 16:00:49 UTC) #8
Marc Treib
+kenrb for IPC - please look at chrome/common/instant.mojom, thanks!
3 years, 7 months ago (2017-05-02 08:09:40 UTC) #10
kenrb
ipc lgtm
3 years, 7 months ago (2017-05-02 13:33:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852693002/40001
3 years, 7 months ago (2017-05-02 13:57:09 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 14:00:56 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5bd9e2fd296b774e34d04cddfb09...

Powered by Google App Engine
This is Rietveld 408576698