Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2845383002: Remove SearchIPCRouter::Delegate::OnInstantSupportDetermined (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
Bernhard Bauer, sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SearchIPCRouter::Delegate::OnInstantSupportDetermined SearchTabHelper doesn't need it anymore. We can set the proper state already in NavigationEntryCommitted. This is part of a series of CLs to get rid of the notion of "Instant support" entirely, see https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41 BUG=627747 Review-Url: https://codereview.chromium.org/2845383002 Cr-Commit-Position: refs/heads/master@{#468959} Committed: https://chromium.googlesource.com/chromium/src/+/5ee95313a9ab33bd01f0ffd2c803f91d5d1c4128

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -42 lines) Patch
M chrome/browser/ui/search/search_ipc_router.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 10 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 2 3 6 chunks +7 lines, -19 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (25 generated)
Marc Treib
3 years, 7 months ago (2017-05-03 08:24:35 UTC) #18
Marc Treib
+bauerb since sfiera is out - could you take a look please?
3 years, 7 months ago (2017-05-03 13:56:55 UTC) #24
Bernhard Bauer
lgtm
3 years, 7 months ago (2017-05-03 14:00:56 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845383002/80001
3 years, 7 months ago (2017-05-03 14:01:28 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 14:07:32 UTC) #30
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5ee95313a9ab33bd01f0ffd2c803...

Powered by Google App Engine
This is Rietveld 408576698