Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2852643002: Fix race with google variation ID registration (Closed)

Created:
3 years, 7 months ago by Raj
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix race with google variation ID registration If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID is called, GWS id will not be registered. This CL fixes that. This CL also renames SetRegisterGoogleVariationID appropriately to SetProfileSigninStatus in some files BUG=714281 Review-Url: https://codereview.chromium.org/2834463005 Cr-Commit-Position: refs/heads/master@{#466464} (cherry picked from commit 96efb190e51a943b44485a8b3c53338498814c43) Review-Url: https://codereview.chromium.org/2852643002 . Cr-Commit-Position: refs/branch-heads/3071@{#284} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f13f69fe4a756b04306ee416f676812f7394826b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/android/data_usage/external_data_use_observer.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/android/data_usage/external_data_use_observer.cc View 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/android/data_usage/external_data_use_observer_bridge.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/android/data_usage/external_data_use_observer_bridge.cc View 3 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Raj
3 years, 7 months ago (2017-04-28 05:54:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f13f69fe4a756b04306ee416f676812f7394826b.

Powered by Google App Engine
This is Rietveld 408576698