Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2852433002: Revert of PPC/s390: SmiUntag only for 32bit (Closed)

Created:
3 years, 7 months ago by JaideepBajwa
Modified:
3 years, 7 months ago
Reviewers:
john.yan, JoranSiu
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC/s390: SmiUntag only for 32bit (patchset #1 id:1 of https://codereview.chromium.org/2842843005/ ) Reason for revert: few tests are failing with stack overflow, will reland with the fix. Original issue's description: > PPC/s390: SmiUntag only for 32bit > > R=joransiu@ca.ibm.com, jyan@ca.ibm.com > BUG= > LOG=n > > Review-Url: https://codereview.chromium.org/2842843005 > Cr-Commit-Position: refs/heads/master@{#44908} > Committed: https://chromium.googlesource.com/v8/v8/+/76dfdb7a32c4be41190ff6a01b23905976e5e0ff TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2852433002 Cr-Commit-Position: refs/heads/master@{#44936} Committed: https://chromium.googlesource.com/v8/v8/+/cef9effe66d909a3672dbcb0b28434df8b905d1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
JaideepBajwa
Created Revert of PPC/s390: SmiUntag only for 32bit
3 years, 7 months ago (2017-04-27 13:32:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852433002/1
3 years, 7 months ago (2017-04-27 13:33:03 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-04-27 13:33:04 UTC) #5
john.yan
lgtm
3 years, 7 months ago (2017-04-27 13:46:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852433002/1
3 years, 7 months ago (2017-04-27 13:47:35 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 13:47:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cef9effe66d909a3672dbcb0b28434df8b9...

Powered by Google App Engine
This is Rietveld 408576698