Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2842843005: PPC/s390: SmiUntag only for 32bit (Closed)

Created:
3 years, 8 months ago by JaideepBajwa
Modified:
3 years, 8 months ago
Reviewers:
john.yan, JoranSiu
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: SmiUntag only for 32bit R=joransiu@ca.ibm.com, jyan@ca.ibm.com BUG= LOG=n Review-Url: https://codereview.chromium.org/2842843005 Cr-Commit-Position: refs/heads/master@{#44908} Committed: https://chromium.googlesource.com/v8/v8/+/76dfdb7a32c4be41190ff6a01b23905976e5e0ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
3 years, 8 months ago (2017-04-26 21:28:56 UTC) #1
JoranSiu
On 2017/04/26 21:28:56, JaideepBajwa wrote: > ptal lgtm
3 years, 8 months ago (2017-04-26 21:32:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842843005/1
3 years, 8 months ago (2017-04-26 21:34:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/76dfdb7a32c4be41190ff6a01b23905976e5e0ff
3 years, 8 months ago (2017-04-26 22:00:04 UTC) #7
JaideepBajwa
3 years, 7 months ago (2017-04-27 13:32:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2852433002/ by bjaideep@ca.ibm.com.

The reason for reverting is: few tests are failing with stack overflow, will
reland with the fix..

Powered by Google App Engine
This is Rietveld 408576698