third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp - Issue 2852423002: Expose passwords to JavaScript in Credential Manager API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

Issue 2852423002: Expose passwords to JavaScript in Credential Manager API (Closed)

Patch Set: Console Message Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/Deprecation.cpp ('K') | « third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl ('k') | third_party/WebKit/Source/modules/fetch/RequestInit.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

index e77c62dbf63a78805bdd63e2d3928c797db5780c..700fcb68cbf4ff937dde6c2bcc300a6449fbc2b2 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

@@ -67,7 +67,7 @@ TEST_F(PasswordCredentialTest, CreateFromMultipartForm) {

EXPECT_EQ("thePassword", credential->passwordName());

EXPECT_EQ("musterman", credential->id());

- EXPECT_EQ("sekrit", credential->Password());

+ EXPECT_EQ("sekrit", credential->password());

EXPECT_EQ(KURL(kParsedURLString, "https://example.com/photo"),

credential->iconURL());

EXPECT_EQ("friendly name", credential->name());

@@ -102,7 +102,7 @@ TEST_F(PasswordCredentialTest, CreateFromURLEncodedForm) {