Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: third_party/WebKit/Source/modules/fetch/RequestInit.cpp

Issue 2852423002: Expose passwords to JavaScript in Credential Manager API (Closed)
Patch Set: Console Message Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/RequestInit.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/RequestInit.cpp b/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
index 1bc75417052eaf90954ce34538ee34f8353450e6..adb7077c13a58496e190836fcf858cab66fe1272 100644
--- a/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
+++ b/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
@@ -14,6 +14,8 @@
#include "bindings/modules/v8/V8PasswordCredential.h"
#include "core/dom/URLSearchParams.h"
#include "core/fileapi/Blob.h"
+#include "core/frame/Deprecation.h"
+#include "core/frame/UseCounter.h"
#include "core/html/FormData.h"
#include "modules/fetch/BlobBytesConsumer.h"
#include "modules/fetch/FormDataBytesConsumer.h"
@@ -115,6 +117,8 @@ RequestInit::RequestInit(ExecutionContext* context,
if (is_credential_set) {
if (V8PasswordCredential::hasInstance(v8_credential, isolate)) {
+ Deprecation::CountDeprecation(context,
+ UseCounter::kCredentialManagerCustomFetch);
// TODO(mkwst): According to the spec, we'd serialize this once we touch
// the network. We're serializing it here, ahead of time, because lifetime
// issues around ResourceRequest make it pretty difficult to pass a

Powered by Google App Engine
This is Rietveld 408576698