Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2852423002: Expose passwords to JavaScript in Credential Manager API (Closed)
Patch Set: Console Message Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 9e57feba393d5fc99995a8cea49200d3a09ebf36..0499bd8a40f5638ac11bcea5e7f31fe8159c0fa7 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -413,6 +413,18 @@ String Deprecation::DeprecationMessage(UseCounter::Feature feature) {
"the CredentialRequestOptions.mediation enum", M62,
"6076479909658624");
+ case UseCounter::kCredentialManagerIdName:
+ case UseCounter::kCredentialManagerPasswordName:
+ case UseCounter::kCredentialManagerAdditionalData:
+ case UseCounter::kCredentialManagerCustomFetch:
jdoerrie 2017/05/22 11:35:31 Should we just collapse this into one enum value t
+ return String::Format(
+ "Passing 'PasswordCredential' objects into 'fetch(..., { "
+ "credentials: ... })' is deprecated, and will be removed in %s. See "
+ "https://www.chromestatus.com/features/5689327799500800 for more "
+ "details and https://www.chromium.org/developers/"
+ "recent-changes-credential-management-api for migration suggestions.",
+ milestoneString(M62));
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();

Powered by Google App Engine
This is Rietveld 408576698