Issue 285213003: Oilpan: move Node traversal objects to the heap.

Issue 285213003: Oilpan: move Node traversal objects to the heap. (Closed)

Created:
6 years, 7 months ago by sof

Modified:
6 years, 7 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: move Node traversal objects to the heap. Add Oilpan transition types to NodeIterator, TreeIterator and NodeFilter objects. R=haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174262

Patch Set 1 #

Patch Set 2 : Add virtual to NodeIteratorBase::trace #

Total comments: 5

Patch Set 3 : Drop nullptr type conversions #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -86 lines)			Patch
M	Source/bindings/scripts/v8_types.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/V8Binding.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8Binding.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/V8NodeFilterCondition.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.h	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 2	7 chunks	+18 lines, -17 lines	0 comments	Download
M	Source/core/dom/NodeFilter.h	View		3 chunks	+11 lines, -8 lines	0 comments	Download
M	Source/core/dom/NodeFilter.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/dom/NodeFilter.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/NodeFilterCondition.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	Source/core/dom/NodeIterator.h	View	1 2	3 chunks	+25 lines, -11 lines	0 comments	Download
M	Source/core/dom/NodeIterator.cpp	View	1 2	7 chunks	+17 lines, -10 lines	0 comments	Download
M	Source/core/dom/NodeIterator.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/NodeIteratorBase.h	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download
M	Source/core/dom/NodeIteratorBase.cpp	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	Source/core/dom/TreeWalker.h	View		3 chunks	+11 lines, -7 lines	0 comments	Download
M	Source/core/dom/TreeWalker.cpp	View		10 chunks	+18 lines, -12 lines	0 comments	Download
M	Source/core/dom/TreeWalker.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/285213003/diff/20001/Source/bindings/scripts/v8_types.py File Source/bindings/scripts/v8_types.py (right): https://codereview.chromium.org/285213003/diff/20001/Source/bindings/scripts/v8_types.py#newcode111 Source/bindings/scripts/v8_types.py:111: 'NodeFilter': 'RefPtrWillBeRawPtr<NodeFilter>', (Nit: Not related to this CL, ...

6 years, 7 months ago (2014-05-18 08:45:48 UTC) #2

sof

Thanks much for the review. https://codereview.chromium.org/285213003/diff/20001/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/285213003/diff/20001/Source/core/dom/Document.cpp#newcode1547 Source/core/dom/Document.cpp:1547: return NodeIterator::create(root, NodeFilter::SHOW_ALL, PassRefPtrWillBeRawPtr<NodeFilter>(nullptr)); ...

6 years, 7 months ago (2014-05-18 17:19:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/285213003/40001

6 years, 7 months ago (2014-05-18 17:19:36 UTC) #5

Message was sent while issue was closed.

Change committed as 174262

Expand Messages | Collapse Messages