Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: Source/core/dom/NodeFilter.h

Issue 285213003: Oilpan: move Node traversal objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Drop nullptr type conversions Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/NodeFilter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/NodeFilter.h
diff --git a/Source/core/dom/NodeFilter.h b/Source/core/dom/NodeFilter.h
index c3b61b7a1583117340b8aad756865f88505a2b79..a52520e3806c59c2848a50abf512596d10ffd9b0 100644
--- a/Source/core/dom/NodeFilter.h
+++ b/Source/core/dom/NodeFilter.h
@@ -27,11 +27,12 @@
#include "bindings/v8/ScriptWrappable.h"
#include "core/dom/NodeFilterCondition.h"
+#include "platform/heap/Handle.h"
#include "wtf/RefPtr.h"
namespace WebCore {
-class NodeFilter : public RefCounted<NodeFilter>, public ScriptWrappable {
+class NodeFilter FINAL : public RefCountedWillBeGarbageCollectedFinalized<NodeFilter>, public ScriptWrappable {
public:
/**
* The following constants are returned by the acceptNode()
@@ -65,25 +66,27 @@ public:
SHOW_NOTATION = 0x00000800
};
- static PassRefPtr<NodeFilter> create(PassRefPtr<NodeFilterCondition> condition)
+ static PassRefPtrWillBeRawPtr<NodeFilter> create(PassRefPtrWillBeRawPtr<NodeFilterCondition> condition)
{
- return adoptRef(new NodeFilter(condition));
+ return adoptRefWillBeNoop(new NodeFilter(condition));
}
- static PassRefPtr<NodeFilter> create()
+ static PassRefPtrWillBeRawPtr<NodeFilter> create()
{
- return adoptRef(new NodeFilter());
+ return adoptRefWillBeNoop(new NodeFilter());
}
short acceptNode(Node*, ExceptionState&) const;
- void setCondition(PassRefPtr<NodeFilterCondition> condition)
+ void setCondition(PassRefPtrWillBeRawPtr<NodeFilterCondition> condition)
{
m_condition = condition;
}
+ void trace(Visitor*);
+
private:
- explicit NodeFilter(PassRefPtr<NodeFilterCondition> condition) : m_condition(condition)
+ explicit NodeFilter(PassRefPtrWillBeRawPtr<NodeFilterCondition> condition) : m_condition(condition)
{
ScriptWrappable::init(this);
}
@@ -93,7 +96,7 @@ private:
ScriptWrappable::init(this);
}
- RefPtr<NodeFilterCondition> m_condition;
+ RefPtrWillBeMember<NodeFilterCondition> m_condition;
};
} // namespace WebCore
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/NodeFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698