Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: Source/bindings/v8/V8Binding.cpp

Issue 285213003: Oilpan: move Node traversal objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Drop nullptr type conversions Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/V8NodeFilterCondition.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 WTF::ArrayBufferContents::freeMemory(data, size); 137 WTF::ArrayBufferContents::freeMemory(data, size);
138 } 138 }
139 }; 139 };
140 140
141 v8::ArrayBuffer::Allocator* v8ArrayBufferAllocator() 141 v8::ArrayBuffer::Allocator* v8ArrayBufferAllocator()
142 { 142 {
143 DEFINE_STATIC_LOCAL(ArrayBufferAllocator, arrayBufferAllocator, ()); 143 DEFINE_STATIC_LOCAL(ArrayBufferAllocator, arrayBufferAllocator, ());
144 return &arrayBufferAllocator; 144 return &arrayBufferAllocator;
145 } 145 }
146 146
147 PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value> callback, v8::Isolate* isolate) 147 PassRefPtrWillBeRawPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value> callback, v8::Isolate* isolate)
148 { 148 {
149 RefPtr<NodeFilter> filter = NodeFilter::create(); 149 RefPtrWillBeRawPtr<NodeFilter> filter = NodeFilter::create();
150 150
151 // FIXME: Should pass in appropriate creationContext 151 // FIXME: Should pass in appropriate creationContext
152 v8::Handle<v8::Object> filterWrapper = toV8(filter, v8::Handle<v8::Object>() , isolate).As<v8::Object>(); 152 v8::Handle<v8::Object> filterWrapper = toV8(filter, v8::Handle<v8::Object>() , isolate).As<v8::Object>();
153 153
154 RefPtr<NodeFilterCondition> condition = V8NodeFilterCondition::create(callba ck, filterWrapper, isolate); 154 RefPtrWillBeRawPtr<NodeFilterCondition> condition = V8NodeFilterCondition::c reate(callback, filterWrapper, isolate);
155 filter->setCondition(condition.release()); 155 filter->setCondition(condition.release());
156 156
157 return filter.release(); 157 return filter.release();
158 } 158 }
159 159
160 const int32_t kMaxInt32 = 0x7fffffff; 160 const int32_t kMaxInt32 = 0x7fffffff;
161 const int32_t kMinInt32 = -kMaxInt32 - 1; 161 const int32_t kMinInt32 = -kMaxInt32 - 1;
162 const uint32_t kMaxUInt32 = 0xffffffff; 162 const uint32_t kMaxUInt32 = 0xffffffff;
163 const int64_t kJSMaxInteger = 0x20000000000000LL - 1; // 2^53 - 1, maximum uniqu ely representable integer in ECMAScript. 163 const int64_t kJSMaxInteger = 0x20000000000000LL - 1; // 2^53 - 1, maximum uniqu ely representable integer in ECMAScript.
164 164
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
791 { 791 {
792 return m_scriptState.get(); 792 return m_scriptState.get();
793 } 793 }
794 794
795 v8::Isolate* V8ExecutionScope::isolate() const 795 v8::Isolate* V8ExecutionScope::isolate() const
796 { 796 {
797 return m_scriptState->isolate(); 797 return m_scriptState->isolate();
798 } 798 }
799 799
800 } // namespace WebCore 800 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/V8NodeFilterCondition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698