Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: components/gcm_driver/android/component_jni_registrar.h

Issue 285203005: Hook components/gcm_driver up to JNI Generator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, and add GCMDriver.java to fix compile Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/android/component_jni_registrar.h
diff --git a/components/gcm_driver/android/component_jni_registrar.h b/components/gcm_driver/android/component_jni_registrar.h
new file mode 100644
index 0000000000000000000000000000000000000000..b2a67c4b8a3f4c9a79c7b16bb4f06f9469bcbf98
--- /dev/null
+++ b/components/gcm_driver/android/component_jni_registrar.h
@@ -0,0 +1,21 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_GCM_DRIVER_ANDROID_COMPONENT_JNI_REGISTRAR_H_
+#define COMPONENTS_GCM_DRIVER_ANDROID_COMPONENT_JNI_REGISTRAR_H_
+
+#include <jni.h>
jianli 2014/05/15 18:13:39 nit: probably you don't need to include this heade
johnme 2014/05/15 19:29:42 Unfortunately, JNIEnv is defined as: struct _JNIE
+
+namespace gcm {
jianli 2014/05/15 18:13:39 Wrong namespace. I am also going to update namespa
jianli 2014/05/15 19:04:43 We decide not to update namespace to gcm_driver at
+
+namespace android {
+
+// Register all JNI bindings necessary for the gcm_driver component.
+bool RegisterGCMDriverJni(JNIEnv* env);
+
+} // namespace android
+
+} // namespace gcm
+
+#endif // COMPONENTS_GCM_DRIVER_ANDROID_COMPONENT_JNI_REGISTRAR_H_

Powered by Google App Engine
This is Rietveld 408576698