components/gcm_driver/android/component_jni_registrar.h - Issue 285203005: Hook components/gcm_driver up to JNI Generator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/gcm_driver/android/component_jni_registrar.h

Issue 285203005: Hook components/gcm_driver up to JNI Generator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, and add GCMDriver.java to fix compile Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/gcm_driver.gypi ('K') | « components/gcm_driver/DEPS ('k') | components/gcm_driver/android/component_jni_registrar.cc » ('j') | components/gcm_driver/android/component_jni_registrar.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_GCM_DRIVER_ANDROID_COMPONENT_JNI_REGISTRAR_H_

	6 #define COMPONENTS_GCM_DRIVER_ANDROID_COMPONENT_JNI_REGISTRAR_H_

	7

	8 #include <jni.h>
	jianli 2014/05/15 18:13:39 nit: probably you don't need to include this heade nit: probably you don't need to include this header file. Instead, you can forward declare JNIEnv. johnme 2014/05/15 19:29:42 Unfortunately, JNIEnv is defined as: struct _JNIE Show quoted text On 2014/05/15 18:13:39, jianli wrote: > nit: probably you don't need to include this header file. Instead, you can > forward declare JNIEnv. Unfortunately, JNIEnv is defined as: struct _JNIEnv; #if defined(__cplusplus) typedef _JNIEnv JNIEnv; #else typedef const struct JNINativeInterface* JNIEnv; #endif and you can't forward declare a typedef without exposing implementation details[1] :-\| [1]: http://stackoverflow.com/questions/804894/forward-declaration-of-a-typedef-in-c
	9

	10 namespace gcm {
	jianli 2014/05/15 18:13:39 Wrong namespace. I am also going to update namespa Wrong namespace. I am also going to update namespace in other gcm component files to use gcm_driver namespace. jianli 2014/05/15 19:04:43 We decide not to update namespace to gcm_driver at Show quoted text On 2014/05/15 18:13:39, jianli wrote: > Wrong namespace. I am also going to update namespace in other gcm component > files to use gcm_driver namespace. We decide not to update namespace to gcm_driver at this moment. We're going to do it after all files have been componentized. So you can keep using gcm namespace.
	11

	12 namespace android {

	13

	14 // Register all JNI bindings necessary for the gcm_driver component.

	15 bool RegisterGCMDriverJni(JNIEnv* env);

	16

	17 } // namespace android

	18

	19 } // namespace gcm

	20

	21 #endif // COMPONENTS_GCM_DRIVER_ANDROID_COMPONENT_JNI_REGISTRAR_H_

OLD	NEW