Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/gcm_driver.gypi

Issue 285203005: Hook components/gcm_driver up to JNI Generator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, and add GCMDriver.java to fix compile Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver.gypi
diff --git a/components/gcm_driver.gypi b/components/gcm_driver.gypi
index 489a710a88ae7bd51e2f5a04a68d645ffc47e04f..7ed86f8b17a74432a8f05786f0b354b485383f87 100644
--- a/components/gcm_driver.gypi
+++ b/components/gcm_driver.gypi
@@ -16,14 +16,54 @@
'..',
],
'sources': [
+ 'gcm_driver/android/component_jni_registrar.cc',
+ 'gcm_driver/android/component_jni_registrar.h',
'gcm_driver/default_gcm_app_handler.cc',
'gcm_driver/default_gcm_app_handler.h',
'gcm_driver/gcm_app_handler.h',
'gcm_driver/gcm_client_factory.cc',
'gcm_driver/gcm_client_factory.h',
+ 'gcm_driver/gcm_driver_android.cc',
fgorski 2014/05/15 17:38:02 Will it be correct to build jni* and android* sour
johnme 2014/05/15 17:54:14 Files whose path includes (^|/)android/ or that en
+ 'gcm_driver/gcm_driver_android.h',
'gcm_driver/system_encryptor.cc',
'gcm_driver/system_encryptor.h',
],
+ 'conditions': [
+ ['OS == "android"', {
+ 'dependencies': [
+ 'gcm_driver_jni_headers',
+ ],
+ }],
+ ],
},
],
+ 'conditions': [
+ ['OS=="android"', {
jianli 2014/05/15 18:13:39 nit: space before and after '=='
johnme 2014/05/15 19:29:42 Done (though technically, no spaces is 3x more com
+ 'targets': [
+ {
+ 'target_name': 'gcm_driver_java',
+ 'type': 'none',
+ 'dependencies': [
+ '../base/base.gyp:base',
+ ],
+ 'variables': {
+ 'java_in_dir': 'gcm_driver/android/java',
+ },
+ 'includes': [ '../build/java.gypi' ],
+ },
+ {
+ 'target_name': 'gcm_driver_jni_headers',
+ 'type': 'none',
+ 'sources': [
+ 'gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java',
+ ],
+ 'variables': {
+ 'jni_gen_package': 'components/gcm_driver',
+ },
+ 'includes': [ '../build/jni_generator.gypi' ],
+ },
+ ],
+ },
+ ],
+ ],
}

Powered by Google App Engine
This is Rietveld 408576698