Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2851983002: [LayoutNG] Change anonymous LayoutBlockFlow to LayoutNGBlockFlow (Closed)

Created:
3 years, 7 months ago by ikilpatrick
Modified:
3 years, 7 months ago
Reviewers:
Gleb Lanbin, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Change anonymous LayoutBlockFlow to LayoutNGBlockFlow Additionally this resolves an incoming margin strut once we know the inline node isn't empty. In this respect we treat it like a zero-height div. This regresses some tests that were using the existing LayoutBlockFlow layout. I.e. when we are inside a LayoutTableCell. BUG=635619 Review-Url: https://codereview.chromium.org/2851983002 Cr-Commit-Position: refs/heads/master@{#468470} Committed: https://chromium.googlesource.com/chromium/src/+/dc843fac8da1a46453dd6035c910c07f5237922c

Patch Set 1 #

Patch Set 2 : testexpectations #

Patch Set 3 : fix test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 6 chunks +12 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 3 chunks +11 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (13 generated)
ikilpatrick
3 years, 7 months ago (2017-05-01 17:51:45 UTC) #5
Gleb Lanbin
lgtm
3 years, 7 months ago (2017-05-01 17:55:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851983002/40001
3 years, 7 months ago (2017-05-01 18:34:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/424509)
3 years, 7 months ago (2017-05-01 18:46:41 UTC) #13
ikilpatrick
+eae for core/layout :)
3 years, 7 months ago (2017-05-01 18:47:01 UTC) #15
eae
LGTM
3 years, 7 months ago (2017-05-01 18:49:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851983002/40001
3 years, 7 months ago (2017-05-01 18:50:05 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:58:16 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dc843fac8da1a46453dd6035c910...

Powered by Google App Engine
This is Rietveld 408576698