[LayoutNG] Move NGInlineNode data to NGInlineNodeData.

[LayoutNG] Move NGInlineNode data to NGInlineNodeData.

In preparation for making NGInlineNode, NGBlockNode POD-like.

BUG=636993
Review-Url: https://codereview.chromium.org/2836293004
Cr-Commit-Position: refs/heads/master@{#468547}
Committed: https://chromium.googlesource.com/chromium/src/+/4b3d57d3066c29135644cf93bd3b3e8092aeeed2

[ikilpatrick, 2017-04-26 00:36:10]

ikilpatrick@chromium.org changed reviewers:
+ eae@chromium.org, kojii@chromium.org

[ikilpatrick, 2017-04-26 00:36:11]

I just got this to compile... looking for input onto how to access the Data().

We could have:

Data().text_content_
MutableData().text_content_

or

TextContent()
MutableTextContent()

or

TextContent()
TextContent()

....

thoughts?

[kojii, 2017-04-26 02:21:17]

> looking for input onto how to access the Data()

Any of them work for me, not strong, but text and items are inseparatable, so
mild preference is 1st one?

BTW, I was wondering, could we have the ng_inline_node_data_ on
LayoutNGBlockFlow? If that is sufficient, we don't use memory on stable,
correct?

https://codereview.chromium.org/2836293004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.h (right):

https://codereview.chromium.org/2836293004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.h:296:
rare_data.ng_inline_node_data_ = WTF::WrapUnique(new NGInlineNodeData);
nit: MakeUnique()?
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

[ikilpatrick, 2017-04-27 17:39:15]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 17:40:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-04-27 17:47:56]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 17:48:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 18:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 18:02:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ikilpatrick, 2017-05-01 20:46:35]

PTAL, moved to LayoutNGBlockFlow.

https://codereview.chromium.org/2836293004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.h (right):

https://codereview.chromium.org/2836293004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.h:296:
rare_data.ng_inline_node_data_ = WTF::WrapUnique(new NGInlineNodeData);
On 2017/04/26 02:21:17, kojii wrote:
> nit: MakeUnique()?
>
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

Done.

[ikilpatrick, 2017-05-01 20:46:39]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 20:47:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2017-05-01 22:57:15]

LGTM

[commit-bot: I haz the power, 2017-05-01 22:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 22:57:38]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-05-02 03:11:59]

lgtm, thank you!

[ikilpatrick, 2017-05-02 03:13:43]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2017-05-02 03:14:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 03:20:17]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493694823564480,
"parent_rev": "c613a5600d8bf1d7ca3f14d088cceecdfcc99ca3", "commit_rev":
"4b3d57d3066c29135644cf93bd3b3e8092aeeed2"}

[commit-bot: I haz the power, 2017-05-02 03:20:52]

Description was changed from

==========
[LayoutNG] Move NGInlineNode data to NGInlineNodeData.

In preparation for making NGInlineNode, NGBlockNode POD-like.

BUG=636993
==========

to

==========
[LayoutNG] Move NGInlineNode data to NGInlineNodeData.

In preparation for making NGInlineNode, NGBlockNode POD-like.

BUG=636993

Review-Url: https://codereview.chromium.org/2836293004
Cr-Commit-Position: refs/heads/master@{#468547}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b3d57d3066c29135644cf93bd3b...
==========

[commit-bot: I haz the power, 2017-05-02 03:20:53]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4b3d57d3066c29135644cf93bd3b...