Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2851873002: Temporarily disable error detection for response_start. (Closed)

Created:
3 years, 7 months ago by Bryan McQuade
Modified:
3 years, 7 months ago
Reviewers:
jkarlin, nasko
CC:
chromium-reviews, clamy, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, nasko, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable error detection for response_start. When browser side nav is enabled, we observe an increase in INVALID_ORDER_RESPONSE_START_PARSE_START PageLoadTimingStatus errors, indicating either that we have a parse start value, but no response start value for a page load, or that we have both values, but response start is reported as happening after parse start. Either case is an error & we should figure out what's going on here and try to fix. As a first step, we'll disable this assertion just to see how much it corrects other page load metrics to get us closer to metric counts being the same with and without plznav being enabled. BUG=716587 Review-Url: https://codereview.chromium.org/2851873002 Cr-Commit-Position: refs/heads/master@{#470595} Committed: https://chromium.googlesource.com/chromium/src/+/e6ac8702b2d7c32e3a59f52ce9d9ceb34d7de8a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/page_load_metrics/page_load_tracker.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Bryan McQuade
PTAL, thanks!
3 years, 7 months ago (2017-05-08 18:34:11 UTC) #7
nasko
LGTM
3 years, 7 months ago (2017-05-08 18:43:06 UTC) #9
jkarlin
lgtm
3 years, 7 months ago (2017-05-10 14:43:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851873002/1
3 years, 7 months ago (2017-05-10 15:13:46 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 16:12:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6ac8702b2d7c32e3a59f52ce9d9...

Powered by Google App Engine
This is Rietveld 408576698